From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 20 Sep 2013 12:52:31 +0200 Subject: [U-Boot] [PATCH V4 04/17] usb: gadget: ether: return error from rx_submit if no request In-Reply-To: <1379647780-2623-5-git-send-email-troy.kisky@boundarydevices.com> References: <1379647780-2623-1-git-send-email-troy.kisky@boundarydevices.com> <1379647780-2623-5-git-send-email-troy.kisky@boundarydevices.com> Message-ID: <201309201252.32187.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Troy Kisky, > This prevents a crash if tftpboot is given a bad filename. > > rx_req will be released by eth_reset_config > which is called by eth_disconnect, > which is called using the .disconnect member of usb_gadget_driver by > mv_pullup in mv_udc which is called using the .pullup member of > usb_gadget_ops by usb_gadget_disconnect which is called by usb_eth_halt > which is called using the .halt member of eth_device by eth_halt > which is called by TftpHandler when TFTP_ERR_FILE_NOT_FOUND or > TFTP_ERR_ACCESS_DENIED occurs > > Signed-off-by: Troy Kisky > How do I trigger this? It'd be nice to have a test-case in the commit message. Best regards, Marek Vasut