public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] mx28evk: Propagate the error if cpu_eth_init() fails
Date: Mon, 23 Sep 2013 01:59:03 +0200	[thread overview]
Message-ID: <201309230159.03246.marex@denx.de> (raw)
In-Reply-To: <1379705450-14684-2-git-send-email-festevam@gmail.com>

Dear Fabio Estevam,

> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> If cpu_eth_init() fails we should return the error immediately.
> 
> Cc: Marek Vasut <marex@denx.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Acked-by: Marek Vasut <marex@denx.de>

> ---
>  board/denx/m28evk/m28evk.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/board/denx/m28evk/m28evk.c b/board/denx/m28evk/m28evk.c
> index f4453d6..33d38cf 100644
> --- a/board/denx/m28evk/m28evk.c
> +++ b/board/denx/m28evk/m28evk.c
> @@ -116,6 +116,8 @@ int board_eth_init(bd_t *bis)
>  	int ret;
> 
>  	ret = cpu_eth_init(bis);
> +	if (ret)
> +		return ret;
> 
>  	clrsetbits_le32(&clkctrl_regs->hw_clkctrl_enet,
>  		CLKCTRL_ENET_TIME_SEL_MASK | CLKCTRL_ENET_CLK_OUT_EN,

Best regards,
Marek Vasut

  reply	other threads:[~2013-09-22 23:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-20 19:30 [U-Boot] [PATCH 1/3] mx28evk: Propagate the error if cpu_eth_init() fails Fabio Estevam
2013-09-20 19:30 ` [U-Boot] [PATCH 2/3] " Fabio Estevam
2013-09-22 23:59   ` Marek Vasut [this message]
2013-09-27 12:04   ` Stefano Babic
2013-09-20 19:30 ` [U-Boot] [PATCH 3/3] mx35pdk: Fix error handling in board_late_init() Fabio Estevam
2013-09-23  8:35   ` Stefano Babic
2013-09-27 12:04   ` Stefano Babic
2013-09-27 12:04 ` [U-Boot] [PATCH 1/3] mx28evk: Propagate the error if cpu_eth_init() fails Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201309230159.03246.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox