From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Mon, 23 Sep 2013 01:59:03 +0200
Subject: [U-Boot] [PATCH 2/3] mx28evk: Propagate the error if
	cpu_eth_init() fails
In-Reply-To: <1379705450-14684-2-git-send-email-festevam@gmail.com>
References: <1379705450-14684-1-git-send-email-festevam@gmail.com>
	<1379705450-14684-2-git-send-email-festevam@gmail.com>
Message-ID: <201309230159.03246.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Fabio Estevam,

> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> If cpu_eth_init() fails we should return the error immediately.
> 
> Cc: Marek Vasut <marex@denx.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Acked-by: Marek Vasut <marex@denx.de>

> ---
>  board/denx/m28evk/m28evk.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/board/denx/m28evk/m28evk.c b/board/denx/m28evk/m28evk.c
> index f4453d6..33d38cf 100644
> --- a/board/denx/m28evk/m28evk.c
> +++ b/board/denx/m28evk/m28evk.c
> @@ -116,6 +116,8 @@ int board_eth_init(bd_t *bis)
>  	int ret;
> 
>  	ret = cpu_eth_init(bis);
> +	if (ret)
> +		return ret;
> 
>  	clrsetbits_le32(&clkctrl_regs->hw_clkctrl_enet,
>  		CLKCTRL_ENET_TIME_SEL_MASK | CLKCTRL_ENET_CLK_OUT_EN,

Best regards,
Marek Vasut