public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: zynq: Fix timer loadaddress
Date: Mon, 23 Sep 2013 16:29:42 +0200	[thread overview]
Message-ID: <20130923162942.572e0649@lilith> (raw)
In-Reply-To: <623c0728fe68cefd13c69a3ac056bd190c1f5642.1377668188.git.michal.simek@xilinx.com>

Hi Michal,

On Wed, 28 Aug 2013 07:36:31 +0200, Michal Simek
<michal.simek@xilinx.com> wrote:

> Reload address was written to the counter register
> instead of load register.
> The problem happens when timer expires but never
> reload to ~0UL (it is downcount timer).
> 
> Reported-by: Stephen MacMahon <stephenm@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> 
> ---
>  arch/arm/cpu/armv7/zynq/timer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/cpu/armv7/zynq/timer.c b/arch/arm/cpu/armv7/zynq/timer.c
> index 0133565..3b8d949 100644
> --- a/arch/arm/cpu/armv7/zynq/timer.c
> +++ b/arch/arm/cpu/armv7/zynq/timer.c
> @@ -57,7 +57,7 @@ int timer_init(void)
>  			SCUTIMER_CONTROL_ENABLE_MASK;
> 
>  	/* Load the timer counter register */
> -	writel(0xFFFFFFFF, &timer_base->counter);
> +	writel(0xFFFFFFFF, &timer_base->load);
> 
>  	/*
>  	 * Start the A9Timer device
> --
> 1.8.2.3
> 

Applied bugfix to u-boot-arm/master, thanks!

Amicalement,
-- 
Albert.

      reply	other threads:[~2013-09-23 14:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-28  5:36 [U-Boot] [PATCH] arm: zynq: Fix timer loadaddress Michal Simek
2013-09-23 14:29 ` Albert ARIBAUD [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130923162942.572e0649@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox