[U-Boot] [PATCH v3 01/10] usb: Move 'bmRequestType' USB device request macros from EHCI header

Marek Vasut
2013-09-17T15:23:35Z

Dear Vivek Gautam,

> Hi Marek,
>
> On Tue, Sep 17, 2013 at 8:32 AM, Marek Vasut <marex@denx.de> wrote:
> > Dear Vivek Gautam,
> >
> >> Macros defining bmRequestType field of USB device request,
> >> given in table 9.2 USB 2.0 spec, are rather generic macros
> >> which can be further used by other Host controller stacks.
> >> So moving them to usb_defs header.
> >>
> >> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> >> Cc: Julius Werner <jwerner@chromium.org>
> >> Cc: Simon Glass <sjg@chromium.org>
> >> Cc: Minkyu Kang <mk7.kang@samsung.com>
> >> Cc: Dan Murphy <dmurphy@ti.com>
> >> Cc: Marek Vasut <marex@denx.de>
> >
> > Why not just use include/usb.h ?
>
> The bit field definitions for usb-types usb-recipient, and directions
> are itself defined in usb_defs.h;
> so i thought of keeping their combination just below it, so that it
> would not be difficult to reference.
>
> Please let me know if you want me to move them to include/usb.h

Ah, we already have usb_defs.h , then this is OK. The headers are mess and will
eventually need cleanup too, not in this patchset of course.

Best regards,
Marek Vasut