public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Prevent a U-Boot crash on Wandboard
Date: Mon, 23 Sep 2013 20:50:55 +0200	[thread overview]
Message-ID: <20130923185055.95383380635@gemini.denx.de> (raw)
In-Reply-To: <CAOMZO5Aj56KVTfRqBd3Wq7OiP8q3wA0Yv4evUzerkXFuFvxvHQ@mail.gmail.com>

Dear Fabio Estevam,

In message <CAOMZO5Aj56KVTfRqBd3Wq7OiP8q3wA0Yv4evUzerkXFuFvxvHQ@mail.gmail.com> you wrote:
>
> > Then shouldn't the patch subject/summary be "print command name only
> > if cmdtp is not NULL" rather than the quite uninformative "prevent a
> > crash"?
> 
> Yes, I agree that original subject is a bit misleading.
> 
> When I read it I thought it was a Wandboard related problem.

I don't know if it's only Wandboard, or if other boards are affected,
too (which are these? under which exact test cases?).  In any case.
the problem is not here, but on the caller's side.  It should not call
a function which expects a command name with a NULL pointer passed as
argument.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The Buddha, the Godhead, resides quite as comfortably in the circuits
of a digital computer or the gears of a cycle transmission as he does
at the top of a mountain or in the petals of a flower.
            - R.  Pirsig, "Zen and the Art of Motorcycle Maintenance"

  parent reply	other threads:[~2013-09-23 18:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-23  1:21 [U-Boot] [PATCH] Prevent a U-Boot crash on Wandboard Steven Falco
2013-09-23 11:40 ` Otavio Salvador
2013-09-23 18:47   ` Wolfgang Denk
2013-09-23 16:11 ` Albert ARIBAUD
2013-09-23 16:21   ` Fabio Estevam
2013-09-23 18:18     ` Tom Rini
2013-09-23 18:50     ` Wolfgang Denk [this message]
2013-09-23 19:17       ` Tom Rini
2013-09-23 19:45         ` Tom Rini
2013-09-23 20:44           ` Wolfgang Denk
2013-09-23 23:23             ` Steven Falco
2013-09-23 20:43         ` Wolfgang Denk
2013-09-23 18:45 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130923185055.95383380635@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox