From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V4 01/17] usb: gadget: mv_udc: don't check CONFIG_USB_MAX_CONTROLLER_COUNT
Date: Mon, 23 Sep 2013 23:17:33 +0200 [thread overview]
Message-ID: <201309232317.33349.marex@denx.de> (raw)
In-Reply-To: <5240AAB9.5040404@boundarydevices.com>
Dear Troy Kisky,
> On 9/23/2013 1:23 PM, Troy Kisky wrote:
> > On 9/22/2013 5:05 PM, Marek Vasut wrote:
> >> Dear Troy Kisky,
> >>
> >>> On 9/20/2013 3:45 AM, Marek Vasut wrote:
> >>>> Dear Troy Kisky,
> >>>>
> >>>>> i.mx6 has 1 otg controller, and 3 host ports. So,
> >>>>> CONFIG_USB_MAX_CONTROLLER_COUNT can be greater than 1
> >>>>> even though only 1 device mode controller is supported.
> >>>>>
> >>>>> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
> >>>>
> >>>> The problem is, will the 3 additional ports still work? I suspect they
> >>>> will, but then if you run 'usb reset', the gadget port will also be
> >>>> switched back into USB Host function, no
> >>>>
> >>>> Best regards,
> >>>> Marek Vasut
> >>>
> >>> The next patch checks the OTG id before switching to host mode. If
> >>> it is
> >>> grounded, then it enters
> >>> host mode, otherwise it doesn't. But, running 'usb reset' on a
> >>> netconsole may kill your connection.
> >>
> >> It won't if you properly ignore rhis one controller depending on the
> >> OTG pin
> >> then, no ?
> >
> > I can return an error code from ehci_hcd_init, so that ehci_reset will
> > not be called. But then
> > usb_lowlevel_init will also return an error, which is good for the
> > call from usb_init, but bad
> > for the call in usb_gadget_register_driver.
> >
> > Perhaps I should return a 1, instead of 0, when the otg_id pin is
> > high? And check for < 0
> > before aborting from usb_gadget_register_driver ?
> >
> > Thanks
> > Troy
>
> Or maybe add a parameter to usb_lowlevel_init specifying if I desire
> host or device mode?
Check
[PATCH v4] usb: new board-specific USB init interface
That might give you some ideas.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-09-23 21:17 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 3:29 [U-Boot] [PATCH V4 00/17] Make mv_udc work for i.mx6 Troy Kisky
2013-09-20 3:29 ` [U-Boot] [PATCH V4 01/17] usb: gadget: mv_udc: don't check CONFIG_USB_MAX_CONTROLLER_COUNT Troy Kisky
2013-09-20 10:45 ` Marek Vasut
2013-09-20 18:18 ` Troy Kisky
2013-09-23 0:05 ` Marek Vasut
2013-09-23 20:23 ` Troy Kisky
2013-09-23 20:55 ` Troy Kisky
2013-09-23 21:17 ` Marek Vasut [this message]
2013-09-20 3:29 ` [U-Boot] [PATCH V4 02/17] usb: ehci-mx6: add support for host mode otg port Troy Kisky
2013-09-20 10:51 ` Marek Vasut
2013-09-20 18:27 ` Troy Kisky
2013-09-20 3:29 ` [U-Boot] [PATCH V4 03/17] usb: gadget: ether set wMaxPacketSize Troy Kisky
2013-09-20 10:52 ` Marek Vasut
2013-09-20 18:34 ` Troy Kisky
2013-09-23 0:04 ` Marek Vasut
2013-09-23 19:51 ` Troy Kisky
2013-09-23 21:22 ` Marek Vasut
2013-09-20 3:29 ` [U-Boot] [PATCH V4 04/17] usb: gadget: ether: return error from rx_submit if no request Troy Kisky
2013-09-20 10:52 ` Marek Vasut
2013-09-20 3:29 ` [U-Boot] [PATCH V4 05/17] usb: gadget: mv_udc: split mv_udc.h file Troy Kisky
2013-09-20 3:29 ` [U-Boot] [PATCH V4 06/17] usb: udc: add udc.h include file Troy Kisky
2013-09-20 10:55 ` Marek Vasut
2013-09-20 18:46 ` Troy Kisky
2013-09-20 18:52 ` Marek Vasut
2013-09-20 19:37 ` Troy Kisky
2013-09-20 19:53 ` Marek Vasut
2013-09-20 21:15 ` Troy Kisky
2013-09-20 21:20 ` Marek Vasut
2013-09-20 21:33 ` Troy Kisky
2013-09-20 22:01 ` Marek Vasut
2013-09-21 0:25 ` Troy Kisky
2013-09-20 3:29 ` [U-Boot] [PATCH V4 07/17] usb: gadget: mv_udc: fix typo in error message Troy Kisky
2013-09-20 3:29 ` [U-Boot] [PATCH V4 08/17] usb: gadget: mv_udc: set is_dualspeed = 1 Troy Kisky
2013-09-20 3:29 ` [U-Boot] [PATCH V4 09/17] usb: gadget: mv_udc: fix full speed connections Troy Kisky
2013-09-20 3:29 ` [U-Boot] [PATCH V4 10/17] usb: gadget: mv_udc: optimize bounce Troy Kisky
2013-09-20 10:58 ` Marek Vasut
2013-09-20 18:58 ` Troy Kisky
2013-09-23 0:02 ` Marek Vasut
2013-09-23 19:12 ` Troy Kisky
2013-09-23 21:23 ` Marek Vasut
2013-09-20 3:29 ` [U-Boot] [PATCH V4 11/17] usb: gadget: mv_udc: flush item before head Troy Kisky
2013-09-20 3:29 ` [U-Boot] [PATCH V4 12/17] usb: gadget: mv_udc: optimize ep_enable Troy Kisky
2013-09-20 3:29 ` [U-Boot] [PATCH V4 13/17] usb: gadget: mv_udc: zero transfer descriptor memory on probe Troy Kisky
2013-09-20 3:29 ` [U-Boot] [PATCH V4 14/17] usb: gadget: mv_udc: clear desc upon ep_disable Troy Kisky
2013-09-20 3:29 ` [U-Boot] [PATCH V4 15/17] mx6: iomux: add GPR1 defines for use with nitrogen6x Troy Kisky
2013-09-20 3:29 ` [U-Boot] [PATCH V4 16/17] nitrogen6x: add otg usb host/device mode support Troy Kisky
2013-09-20 4:08 ` Troy Kisky
2013-09-20 3:29 ` [U-Boot] [PATCH V4 17/17] nitrogen6x: add CONFIG_MV_UDC Troy Kisky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201309232317.33349.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox