From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4] usb: new board-specific USB init interface
Date: Tue, 24 Sep 2013 15:15:25 +0200 [thread overview]
Message-ID: <201309241515.25645.marex@denx.de> (raw)
In-Reply-To: <52417D80.5010608@samsung.com>
Dear Minkyu Kang,
> Dear Marek Vasut,
>
> On 19/09/13 23:34, Marek Vasut wrote:
> > Dear Marek Vasut,
> >
> >> Dear Marek Vasut,
> >>
> >>> Dear Mateusz Zalega,
> >>>
> >>>> This commit unifies board-specific USB initialization implementations
> >>>> under one symbol (usb_board_init), declaration of which is available
> >>>> in usb.h.
> >>>>
> >>>> New API allows selective initialization of USB controllers whenever
> >>>> needed.
> >>>>
> >>>> Signed-off-by: Mateusz Zalega <m.zalega@samsung.com>
> >>>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> >>>> Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>
> >>>> Cc: Marek Vasut <marex@denx.de>
> >>>> Cc: Lukasz Majewski <l.majewski@samsung.com>
> >>>> Change-Id: Ia78a1378f30a55dd14598c9a1a1b4b8a762e2cd8
> >>>> ---
> >>>> Changes since RFC (v1):
> >>>> - NVIDIA Tegra doesn't postpone its USB init anymore
> >>>> - board_usb_init()'s sole argument name was shortened
> >>>> - networking code comment style (/* blurb...) dropped
> >>>> - squashed RFC changes so that patch won't break bisect
> >>>>
> >>>> v2 changes:
> >>>> - commit message fixup
> >>>>
> >>>> v3 changes:
> >>>> - added 'index' argument to perform selective port initialization
> >>>>
> >>>> v4 changes:
> >>>> - board_usb_init_fail() renamed to board_usb_cleanup()
> >>>> - board_usb_cleanup() accepts controller index and init type
> >>>> - DFU and UMS commands don't init all USB controllers anymore
> >>>> - minor related fixes & refactorization
> >>>
> >>> How did you test it on all the ARM boards ?
> >>>
> >>> ARCH=arm CROSS_COMPILE=arm-linux-gnueabi-
> >>> BUILD_DIR=/tmp/u-boot-arm-build MAKEALL_LOGDIR=/tmp/u-boot-arm-log
> >>> ./MAKEALL -a arm
> >>>
> >>> does this work for you ?
> >>
> >> Looks like this was a local issue here, sorry for the noise. Once the
> >> builds finish, I will apply for -next.
> >
> > I checked powerpc and "arches" "glacier" and "glacier_nand" don't build.
> > Can you please check and fix ? You can get the ELDK 5.4 PPC toolchain
> > from [1].
> >
> > http://www.denx.de/wiki/ELDK-5/
> >
> > Best regards,
> > Marek Vasut
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot
>
> There are 5 patches that are sent by Mateusz Zalega.
> Since those patches are had dependency with this patch.
> Could please pick up them to -usb?
>
> http://patchwork.ozlabs.org/patch/268786/
> http://patchwork.ozlabs.org/patch/268787/
> http://patchwork.ozlabs.org/patch/268788/
> http://patchwork.ozlabs.org/patch/268789/
>
> http://patchwork.ozlabs.org/patch/268790/
They don't touch any usb core stuff, they're just samsung-specific configuration
adjustments. They should go via u-boot-samsung.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-09-24 13:15 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 10:50 [U-Boot] [RFC 00/10] New board-specific USB initialization interface Mateusz Zalega
2013-08-06 10:50 ` [U-Boot] [RFC 01/10] " Mateusz Zalega
2013-08-07 16:23 ` Stephen Warren
2013-08-11 18:04 ` Marek Vasut
2013-08-12 9:33 ` Mateusz Zalega
2013-08-06 10:50 ` [U-Boot] [RFC 02/10] nvidia, tegra: new USB hardware init interface Mateusz Zalega
2013-08-07 16:26 ` Stephen Warren
2013-08-06 10:50 ` [U-Boot] [RFC 03/10] Voipac PXA270: " Mateusz Zalega
2013-08-06 10:50 ` [U-Boot] [RFC 04/10] Trizeps IV: " Mateusz Zalega
2013-08-06 10:50 ` [U-Boot] [RFC 05/10] Colibri PXA270: " Mateusz Zalega
2013-08-06 10:50 ` [U-Boot] [RFC 06/10] icpdas lp8x4x: " Mateusz Zalega
2013-08-11 18:07 ` Marek Vasut
2013-08-06 10:50 ` [U-Boot] [RFC 07/10] esd pmc440: " Mateusz Zalega
2013-08-06 10:50 ` [U-Boot] [RFC 08/10] esd apc405: " Mateusz Zalega
2013-08-06 10:50 ` [U-Boot] [RFC 09/10] balloon3: " Mateusz Zalega
2013-08-06 10:50 ` [U-Boot] [RFC 10/10] canyonlands: " Mateusz Zalega
2013-08-06 11:40 ` [U-Boot] [RFC 00/10] New board-specific USB initialization interface Wolfgang Denk
2013-08-07 15:57 ` Mateusz Zalega
2013-08-07 16:59 ` Mateusz Zalega
2013-08-07 17:01 ` Wolfgang Denk
2013-08-20 13:35 ` [U-Boot] [PATCH] usb: new board-specific USB init interface Mateusz Zalega
2013-08-21 3:33 ` Marek Vasut
2013-08-21 10:22 ` Mateusz Zalega
2013-08-21 13:08 ` Marek Vasut
2013-08-22 10:32 ` Mateusz Zalega
2013-08-22 19:37 ` Marek Vasut
2013-08-26 10:41 ` Mateusz Zalega
2013-08-27 19:50 ` Marek Vasut
2013-08-21 8:33 ` [U-Boot] [PATCH v2] " Mateusz Zalega
2013-08-27 15:51 ` Mateusz Zalega
2013-09-03 10:41 ` [U-Boot] [PATCH v3] " Mateusz Zalega
2013-09-05 15:50 ` Marek Vasut
2013-09-05 17:37 ` Mateusz Zalega
2013-09-05 17:51 ` Marek Vasut
2013-09-06 11:22 ` Mateusz Zalega
2013-09-06 11:24 ` Marek Vasut
2013-09-06 11:36 ` Mateusz Zalega
2013-09-06 11:40 ` Marek Vasut
2013-09-06 12:17 ` Mateusz Zalega
2013-09-15 14:21 ` Marek Vasut
2013-09-16 8:27 ` Mateusz Zalega
2013-09-10 15:10 ` [U-Boot] [PATCH v4] " Mateusz Zalega
2013-09-15 16:44 ` Marek Vasut
2013-09-16 9:10 ` Mateusz Zalega
2013-09-16 14:24 ` Marek Vasut
2013-09-17 16:11 ` Igor Grinberg
2013-09-18 10:58 ` Mateusz Zalega
2013-09-19 13:34 ` Marek Vasut
2013-09-19 13:40 ` Marek Vasut
2013-09-19 14:34 ` Marek Vasut
2013-09-24 11:54 ` Minkyu Kang
2013-09-24 13:15 ` Marek Vasut [this message]
2013-09-25 11:01 ` Mateusz Zalega
2013-09-26 1:50 ` Marek Vasut
2013-09-26 10:04 ` Mateusz Zalega
2013-10-02 19:11 ` [U-Boot] [PATCH v5] " Mateusz Zalega
2013-10-03 15:16 ` Marek Vasut
2013-10-04 17:22 ` [U-Boot] [PATCH v6] " Mateusz Zalega
2013-10-05 0:48 ` Troy Kisky
2013-10-07 10:32 ` Mateusz Zalega
2013-10-08 0:09 ` Troy Kisky
2013-10-08 10:31 ` Marek Vasut
2013-10-06 13:55 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201309241515.25645.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox