From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Tue, 24 Sep 2013 18:51:36 +0200 Subject: [U-Boot] [PATCH v3] ARM: mxs: tools: Use mkimage for BootStream generation In-Reply-To: References: <1380037157-6700-1-git-send-email-marex@denx.de> <201309241828.46808.marex@denx.de> Message-ID: <201309241851.36836.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Otavio Salvador, > On Tue, Sep 24, 2013 at 1:28 PM, Marek Vasut wrote: > > Dear Otavio Salvador, > > > >> On Tue, Sep 24, 2013 at 12:39 PM, Marek Vasut wrote: > >> > Now that mkimage can generate an BootStream for i.MX23 and i.MX28, > >> > use the mkimage as a default tool to generate the BootStreams instead > >> > of the elftosb tool. This cuts out another obscure dependency. > >> > > >> > Signed-off-by: Marek Vasut > >> > >> .. > >> > >> > # Specify the target for use in elftosb call > >> > > >> > -ELFTOSB_TARGET-$(CONFIG_MX23) = imx23 > >> > -ELFTOSB_TARGET-$(CONFIG_MX28) = imx28 > >> > +MKIMAGE_TARGET-$(CONFIG_MX23) = mx23 > >> > +MKIMAGE_TARGET-$(CONFIG_MX28) = mx28 > >> > > >> > -$(OBJTREE)/u-boot.bd: > >> > $(SRCTREE)/$(CPUDIR)/$(SOC)/u-boot-$(ELFTOSB_TARGET-y).bd > >> > +$(OBJTREE)/mxsimage.cfg: > >> > $(SRCTREE)/$(CPUDIR)/$(SOC)/mxsimage.$(MKIMAGE_TARGET-y).cfg > >> > > >> > sed "s at OBJTREE@$(OBJTREE)@g" $^ > $@ > >> > >> This is clearly a mxsimage thing; I do believe MXSIMAGE_TARGET is more > >> clear. > > > > Please read the patch again, the tool that is invoked is called "mkimage" > > . I disagree. > > But it is used to generate the mxsimage.cfg in > .../mxsimage.$(MKIMAGE_TARGET-y).cfg > > So it is really an mxsimage thing. > > For something named MKIMAGE_TARGET I would expect it being in the mkimage > call. IFF you look at the pattern above (-ELFTOSB -> +MKIMAGE), you can see the name of the variable contains the name of the tool. I want to stick with MKIMAGE_ here. Best regards, Marek Vasut