[U-Boot] [PATCH V5 02/18] usb: ehci-mx6: add support for host mode otg port

Marek Vasut
2013-09-28T00:57:27Z

Dear Troy Kisky,

> On 9/27/2013 1:42 PM, Marek Vasut wrote:
> > }
> >
> > -static void usbh1_oc_config(void)
> > +struct usbnc_regs {
> > + u32 ctrl[4]; /* otg/host1-3 */
> >
> >>> This won't scale. Align this with the # of controllers you claim you
> >>> have here, why dont you?
> >>
> >> You've lost me here. Can you post the struct you'd like to see?
> >
> > Something like u32 ctrl[CONFIG_HOW_MANY_PORTS_YOU_HAVE] or so would
> > suffice. I think you have such a MAX_PORTS #define already.
>
> This structure is a description of the i.mx6 hardware. I could add the
> unreferenced 4 registers that are next
> to make this clearer?

Ah, now I get it. Might be a good idea to add them and also add a comment above.

btw. (strictly for subsequent patchset) I keep wondering why we have EHCI MX6
and EHCI MXS files, even if both use the exact same USB IP block and exact same
USB PHY. Sigh ...

Best regards,
Marek Vasut