From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V5 05/18] usb: gadget: ether: return error from rx_submit if no request
Date: Fri, 27 Sep 2013 19:55:17 +0200 [thread overview]
Message-ID: <201309271955.17868.marex@denx.de> (raw)
In-Reply-To: <1380159678-26416-6-git-send-email-troy.kisky@boundarydevices.com>
Dear Troy Kisky,
> This prevents a crash if tftpboot is given a bad filename.
>
> rx_req will be released by eth_reset_config
> which is called by eth_disconnect,
> which is called using the .disconnect member of usb_gadget_driver by
> mv_pullup in mv_udc which is called using the .pullup member of
> usb_gadget_ops by usb_gadget_disconnect which is called by usb_eth_halt
> which is called using the .halt member of eth_device by eth_halt
> which is called by TftpHandler when TFTP_ERR_FILE_NOT_FOUND or
> TFTP_ERR_ACCESS_DENIED occurs
>
> I trigger this with the following commands
> setenv ipaddr 10.0.0.2 && setenv netmask 255.255.255.0 && setenv serverip
> 10.0.0.1 setenv usbnet_devaddr 00:11:22:33:44:55 && setenv usbnet_hostaddr
> 00:aa:bb:cc:dd:ee setenv ethprime usb_ether && setenv ethact usb_ether &&
> setenv ncip 10.0.0.1 tftpboot 10800000 10.0.0.1:missing_file
>
> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
>
Picking for -next, thanks
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-09-27 17:55 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 1:41 [U-Boot] [PATCH V5 00/18] Make mv_udc work for i.mx6 Troy Kisky
2013-09-26 1:41 ` [U-Boot] [PATCH V5 01/18] usb: gadget: mv_udc: don't check CONFIG_USB_MAX_CONTROLLER_COUNT Troy Kisky
2013-09-26 1:41 ` [U-Boot] [PATCH V5 02/18] usb: ehci-mx6: add support for host mode otg port Troy Kisky
2013-09-27 17:50 ` Marek Vasut
2013-09-27 19:47 ` Troy Kisky
2013-09-27 20:42 ` Marek Vasut
2013-09-27 22:22 ` Troy Kisky
2013-09-28 0:57 ` Marek Vasut
2013-09-26 1:41 ` [U-Boot] [PATCH V5 03/18] usb: echi-hcd: add usb_lowlevel_init_device Troy Kisky
2013-09-27 17:54 ` Marek Vasut
2013-09-27 20:03 ` Troy Kisky
2013-09-27 20:41 ` Marek Vasut
2013-09-26 1:41 ` [U-Boot] [PATCH V5 04/18] usb: gadget: ether set wMaxPacketSize Troy Kisky
2013-09-27 17:54 ` Marek Vasut
2013-09-26 1:41 ` [U-Boot] [PATCH V5 05/18] usb: gadget: ether: return error from rx_submit if no request Troy Kisky
2013-09-27 17:55 ` Marek Vasut [this message]
2013-09-26 1:41 ` [U-Boot] [PATCH V5 06/18] usb: gadget: mv_udc: split mv_udc.h file Troy Kisky
2013-09-26 1:41 ` [U-Boot] [PATCH V5 07/18] usb: udc: add udc.h include file Troy Kisky
2013-09-27 17:57 ` Marek Vasut
2013-09-27 20:07 ` Troy Kisky
2013-09-26 1:41 ` [U-Boot] [PATCH V5 08/18] usb: gadget: mv_udc: fix typo in error message Troy Kisky
2013-09-27 17:58 ` Marek Vasut
2013-09-26 1:41 ` [U-Boot] [PATCH V5 09/18] usb: gadget: mv_udc: set is_dualspeed = 1 Troy Kisky
2013-09-27 17:58 ` Marek Vasut
2013-09-26 1:41 ` [U-Boot] [PATCH V5 10/18] usb: gadget: mv_udc: fix full speed connections Troy Kisky
2013-09-27 18:00 ` Marek Vasut
2013-09-27 20:13 ` Troy Kisky
2013-09-27 20:38 ` Marek Vasut
2013-09-26 1:41 ` [U-Boot] [PATCH V5 11/18] usb: gadget: mv_udc: optimize bounce Troy Kisky
2013-09-26 1:41 ` [U-Boot] [PATCH V5 12/18] usb: gadget: mv_udc: flush item before head Troy Kisky
2013-09-27 18:01 ` Marek Vasut
2013-09-26 1:41 ` [U-Boot] [PATCH V5 13/18] usb: gadget: mv_udc: optimize ep_enable Troy Kisky
2013-09-26 1:41 ` [U-Boot] [PATCH V5 14/18] usb: gadget: mv_udc: zero transfer descriptor memory on probe Troy Kisky
2013-09-27 18:01 ` Marek Vasut
2013-09-26 1:41 ` [U-Boot] [PATCH V5 15/18] usb: gadget: mv_udc: clear desc upon ep_disable Troy Kisky
2013-09-27 18:02 ` Marek Vasut
2013-09-26 1:41 ` [U-Boot] [PATCH V5 16/18] mx6: iomux: add GPR1 defines for use with nitrogen6x Troy Kisky
2013-09-26 1:41 ` [U-Boot] [PATCH V5 17/18] nitrogen6x: add otg usb host/device mode support Troy Kisky
2013-09-26 1:41 ` [U-Boot] [PATCH V5 18/18] nitrogen6x: add CONFIG_MV_UDC Troy Kisky
2013-09-26 16:18 ` [U-Boot] [PATCH V5 00/18] Make mv_udc work for i.mx6 Stefano Babic
2013-09-26 19:13 ` Troy Kisky
2013-09-26 20:24 ` Marek Vasut
2013-09-27 18:03 ` Marek Vasut
2013-09-27 20:14 ` Troy Kisky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201309271955.17868.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox