From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 27 Sep 2013 19:55:17 +0200 Subject: [U-Boot] [PATCH V5 05/18] usb: gadget: ether: return error from rx_submit if no request In-Reply-To: <1380159678-26416-6-git-send-email-troy.kisky@boundarydevices.com> References: <1380159678-26416-1-git-send-email-troy.kisky@boundarydevices.com> <1380159678-26416-6-git-send-email-troy.kisky@boundarydevices.com> Message-ID: <201309271955.17868.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Troy Kisky, > This prevents a crash if tftpboot is given a bad filename. > > rx_req will be released by eth_reset_config > which is called by eth_disconnect, > which is called using the .disconnect member of usb_gadget_driver by > mv_pullup in mv_udc which is called using the .pullup member of > usb_gadget_ops by usb_gadget_disconnect which is called by usb_eth_halt > which is called using the .halt member of eth_device by eth_halt > which is called by TftpHandler when TFTP_ERR_FILE_NOT_FOUND or > TFTP_ERR_ACCESS_DENIED occurs > > I trigger this with the following commands > setenv ipaddr 10.0.0.2 && setenv netmask 255.255.255.0 && setenv serverip > 10.0.0.1 setenv usbnet_devaddr 00:11:22:33:44:55 && setenv usbnet_hostaddr > 00:aa:bb:cc:dd:ee setenv ethprime usb_ether && setenv ethact usb_ether && > setenv ncip 10.0.0.1 tftpboot 10800000 10.0.0.1:missing_file > > Signed-off-by: Troy Kisky > Picking for -next, thanks Best regards, Marek Vasut