public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] usb: Prevent using reserved registers on DM36x usb
Date: Mon, 30 Sep 2013 01:26:23 +0200	[thread overview]
Message-ID: <201309300126.23729.marex@denx.de> (raw)
In-Reply-To: <1380474142-16686-1-git-send-email-amurray@embedded-bits.co.uk>

Dear Andrew Murray,

> The musb driver defines and uses MUSB_CSR0_H_DIS_PING, however this
> bit is reserved on the DM36x. Thus this patch ensures that the
> reserved bit is not accesssed.
> 
> It has been observed that some USB devices will fail to enumerate
> with errors such as 'error in inquiry' without this patch.
> 
> See http://www.ti.com/litv/pdf/sprufh9a for details.
> 
> Cc: Marek Vasut <marex@denx.de>
> Cc: Tom Rini <trini@ti.com>
> Signed-off-by: Andrew Murray <amurray@embedded-bits.co.uk>

Tom, can you check this and if it's OK with you, pick this by hand?

For my part, I'm fine here,

Acked-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut

  reply	other threads:[~2013-09-29 23:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-29 17:02 [U-Boot] [PATCH v2] usb: Prevent using reserved registers on DM36x usb Andrew Murray
2013-09-29 23:26 ` Marek Vasut [this message]
2013-10-09 17:16   ` Andrew Murray
2013-10-09 17:44     ` Tom Rini
2013-10-10 12:57 ` [U-Boot] [U-Boot, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201309300126.23729.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox