From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx6: Add IOMUX_CONFIG_SION flag to all GPIO pins
Date: Tue, 1 Oct 2013 14:43:22 +0200 [thread overview]
Message-ID: <201310011443.22955.marex@denx.de> (raw)
In-Reply-To: <CAP9ODKrW3g0yjT8SUH-P+TmrJWHesenAid-rM3mPcrHv27b0Ew@mail.gmail.com>
Dear Otavio Salvador,
> On Tue, Oct 1, 2013 at 5:33 AM, Stefano Babic <sbabic@denx.de> wrote:
> > Hi Otavio,
> >
> > On 30/09/2013 00:15, Otavio Salvador wrote:
> >> The IOMUX_CONFIG_SION allows for reading PAD value from PSR register.
> >>
> >> The following quote from the datasheet:
> >>
> >> ,----
> >>
> >> | ...
> >> | 28.4.2.2 GPIO Write Mode
> >> | The programming sequence for driving output signals should be as
> >> | follows: 1. Configure IOMUX to select GPIO mode (Via IOMUXC), also
> >> | enable SION if need to read loopback pad value through PSR
> >> | 2. Configure GPIO direction register to output (GPIO_GDIR[GDIR] set to
> >> | 1b). 3. Write value to data register (GPIO_DR).
> >> | ...
> >>
> >> `----
> >>
> >> This fixes the gpio_get_value to properly work when a GPIO is set for
> >> output and has no conflicts.
> >>
> >> Thanks for Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>, Fabio
> >> Estevam <fabio.estevam@freescale.com> and Eric B?nard
> >> <eric@eukrea.com> for helping to properly trace this down.
> >>
> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >> ---
> >
> > I come later in the discussion, but I see you all have found the
> > solution ;-).
> >
> > I suggest you add in the commit message that this patch is only for
> > i.MX6 (if you do not plan to extend it to the other i.MXes...), so that
> > we can track that the same must be done also for the other SOCs.
>
> I think this is clear from the commit prefix.
The commit message should be ARM: mx6: or such btw.
It'd be nice to fix it up for MX5 as well so we're consistent.
> I am under heavy load now and I cannot check their datasheet to verify
> if they all need this or not.
>
> If someone does not does it, I can take a look for sure.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-10-01 12:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-29 22:15 [U-Boot] [PATCH] mx6: Add IOMUX_CONFIG_SION flag to all GPIO pins Otavio Salvador
2013-10-01 8:33 ` Stefano Babic
2013-10-01 12:01 ` Otavio Salvador
2013-10-01 12:43 ` Marek Vasut [this message]
2013-10-01 13:08 ` Otavio Salvador
2013-10-01 14:21 ` Eric Nelson
2013-10-01 13:13 ` Stefano Babic
2013-10-01 14:26 ` Eric Nelson
2013-10-01 14:49 ` Stefano Babic
2013-10-01 15:56 ` Eric Nelson
2013-10-01 16:10 ` Stefano Babic
2013-10-01 16:17 ` Eric Nelson
2013-10-01 19:50 ` Benoît Thébaudeau
2013-10-01 20:01 ` Otavio Salvador
2013-10-01 20:21 ` Benoît Thébaudeau
2013-10-01 20:25 ` Fabio Estevam
2013-10-01 21:29 ` Eric Nelson
2013-10-02 6:06 ` Stefano Babic
2013-10-01 16:23 ` Benoît Thébaudeau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201310011443.22955.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox