From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] SPL: Add CONFIG_SPL_BOOTCOUNT_SUPPORT
Date: Wed, 2 Oct 2013 09:14:27 -0400 [thread overview]
Message-ID: <20131002131427.GF15917@bill-the-cat> (raw)
In-Reply-To: <52491C44.80906@denx.de>
On Mon, Sep 30, 2013 at 08:37:56AM +0200, Stefan Roese wrote:
> Hi Tom,
>
> On 27.09.2013 21:26, Tom Rini wrote:
> > Add a new symbol, CONFIG_SPL_BOOTCOUNT_SUPPORT, to make use of the
> > existing BOOTCOUNT_SUPPORT within SPL. It is strongly discouraged to
> > use bootcount in both SPL and full U-Boot, as they use the same counter.
>
> I just noticed that I missed sending the SPL bootcount implementation I
> did a few weeks ago to the list. I'll send it shortly. The main
> differences I see right now are:
>
> - My implementation requires CONFIG_BOOTCOUNT_LIMIT and
> CONFIG_SPL_BOOTCOUNT_SUPPORT to be configured
OK, I see where you went with this, and I like this idea better. I
shall incorporate that in v2.
> - The check is not added to the board-specific code, but the
> medium code (here spl_nor.c). This might be consolidated even
> more by moving it to a non-boot-medium specific location (spl.c)?
This I think takes things the wrong way. When it's part of
spl_start_uboot we cover all boot method cases (MMC and NAND, in my
case). Perhaps we should switch to a useful, but still weak default
function?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131002/6ef38eed/attachment.pgp>
next prev parent reply other threads:[~2013-10-02 13:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 19:26 [U-Boot] [PATCH 0/2] Add bootcount support to SPL Tom Rini
2013-09-27 19:26 ` [U-Boot] [PATCH 1/2] SPL: Add CONFIG_SPL_BOOTCOUNT_SUPPORT Tom Rini
2013-09-30 6:37 ` Stefan Roese
2013-10-02 13:14 ` Tom Rini [this message]
2013-09-27 19:26 ` [U-Boot] [PATCH 2/2] am335x: Switch to CONFIG_SPL_BOOTCOUNT_SUPPORT Tom Rini
2013-09-28 1:20 ` [U-Boot] [PATCH 0/2] Add bootcount support to SPL Otavio Salvador
2013-10-02 15:07 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131002131427.GF15917@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox