public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/4] arm64: rela relocation
Date: Sat, 5 Oct 2013 09:55:22 +0200	[thread overview]
Message-ID: <20131005095522.7e590403@lilith> (raw)
In-Reply-To: <4715a8.6877.141842de124.Coremail.fenghua@phytium.com.cn>

Hi FengHua,

On Fri, 4 Oct 2013 23:55:01 +0800 (GMT+08:00), FengHua
<fenghua@phytium.com.cn> wrote:

> 
> 
> > arm64: rela relocation
> > 
> > This lets us remove the manual relocation stuff from the arm64 patchset
> > (the symbol itself is removed by this patchset, but not all the new
> > manual relocations added by the arm64 patchset).
> > 
> > I'm not terribly happy with the way relocate-rela is now, versus something
> > cleaner that operates on the ELF file, but it's good enough for now and
> > waiting longer to get rid of the manual relocations would be worse.
> > 
> > This patchset is based on David's arm64 patchset v13.  David, the first
> > two patches should be applied before your arm64 patches.  Maybe the
> > fourth as well (except for the removal of the arm64 ifdef you added,
> > which would then need to be squashed with your patch).  The third patch
> > should be squashed with your patches (plus you should remove the manual
> > relocs).
> > 
> > Scott Wood (4):
> >   arm64: Add tool to statically apply RELA relocations
> >   arm64: Turn u-boot.bin back into an ELF file after relocate-rela
> >   arm64: Non-manual relocation
> >   arm64: Make checkarmreloc accept arm64 relocations
> > 
> >  Makefile                          |  39 ++++++--
> >  arch/arm/config.mk                |   4 -
> >  arch/arm/cpu/armv8/config.mk      |   1 -
> >  arch/arm/cpu/armv8/u-boot.lds     |  32 +++++--
> >  arch/arm/include/asm/config.h     |   5 --
> >  arch/arm/lib/crt0_64.S            |   7 +-
> >  arch/arm/lib/relocate_64.S        |  41 ++++-----
> >  include/configs/vexpress_aemv8a.h |   3 +
> >  tools/Makefile                    |   6 ++
> >  tools/relocate-rela.c             | 185 ++++++++++++++++++++++++++++++++++++++
> >  10 files changed, 276 insertions(+), 47 deletions(-)
> >  create mode 100644 tools/relocate-rela.c
> > 
> Great, some fixups related with relocation could be removed.
> I will modify arm64 patchset according this.

Stop me if I'm missing something, but doesn't Scott's patch series need
yours? And if you remove the manual relocas in yours, doesn't that make
your series unable to function properly until Scott's series is applied
too?

If I am not mistaken, then maybe Scott's and your patches should be
merged in a single series, with adequate attribution of course. 

> David

Amicalement,
-- 
Albert.

  reply	other threads:[~2013-10-05  7:55 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-03 22:48 [U-Boot] [PATCH 0/4] arm64: rela relocation Scott Wood
2013-10-03 22:48 ` [U-Boot] [PATCH 1/4] arm64: Add tool to statically apply RELA relocations Scott Wood
2013-10-04 16:10   ` FengHua
2013-10-04 16:57     ` Scott Wood
2013-10-05  7:52   ` Albert ARIBAUD
2013-10-08  0:55     ` Scott Wood
2013-10-08  8:10       ` Albert ARIBAUD
2013-10-08 16:22         ` Scott Wood
2013-10-09  9:04           ` Albert ARIBAUD
2013-10-08 14:22   ` FengHua
2013-10-08 15:06     ` Scott Wood
2013-10-03 22:48 ` [U-Boot] [PATCH 2/4] arm64: Turn u-boot.bin back into an ELF file after relocate-rela Scott Wood
2013-10-03 22:48 ` [U-Boot] [PATCH 3/4] arm64: Non-manual relocation Scott Wood
2013-10-04 16:13   ` FengHua
2013-10-04 16:55     ` Scott Wood
2013-10-03 22:48 ` [U-Boot] [PATCH 4/4] arm64: Make checkarmreloc accept arm64 relocations Scott Wood
2013-10-04 15:55 ` [U-Boot] [PATCH 0/4] arm64: rela relocation FengHua
2013-10-05  7:55   ` Albert ARIBAUD [this message]
2013-10-07 16:43     ` Scott Wood
2013-10-08  3:32     ` FengHua
2013-10-08  8:13       ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131005095522.7e590403@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox