From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 01/11] fw_env.c: Increase max dev path to 32
Date: Sat, 05 Oct 2013 22:02:12 +0200 [thread overview]
Message-ID: <20131005200212.37582380A3C@gemini.denx.de> (raw)
In-Reply-To: <1380227287-26057-2-git-send-email-trini@ti.com>
Dear Tom Rini,
In message <1380227287-26057-2-git-send-email-trini@ti.com> you wrote:
> Currently our limit is too small to allow for /dev/mmcblk0boot0 to work,
> for example. Expand to 32 for future needs.
>
> Signed-off-by: Tom Rini <trini@ti.com>
> ---
> tools/env/fw_env.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c
> index 577ce2d..bf5c552 100644
> --- a/tools/env/fw_env.c
> +++ b/tools/env/fw_env.c
> @@ -40,7 +40,7 @@
> _min1 < _min2 ? _min1 : _min2; })
>
> struct envdev_s {
> - char devname[16]; /* Device name */
> + char devname[32]; /* Device name */
Do we really need a static size here? Can we not auto-adjust to the
needed size, say by dynamically allocating the buffer?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The speed of time is one second per second.
next prev parent reply other threads:[~2013-10-05 20:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 20:27 [U-Boot] [PATCH 00/11] NAND/MMC environment in SPL, Falcon Mode enhancements Tom Rini
2013-09-26 20:27 ` [U-Boot] [PATCH 01/11] fw_env.c: Increase max dev path to 32 Tom Rini
2013-10-05 20:02 ` Wolfgang Denk [this message]
2013-10-06 20:55 ` Tom Rini
2013-10-07 5:47 ` Wolfgang Denk
2013-10-07 12:06 ` Tom Rini
2013-09-26 20:27 ` [U-Boot] [PATCH 02/11] env_mmc.c: Make the non-redundant env_relocate_spec use malloc not stack Tom Rini
2013-10-05 20:00 ` Wolfgang Denk
2013-10-06 20:40 ` Tom Rini
2013-10-07 5:41 ` Wolfgang Denk
2013-09-26 20:27 ` [U-Boot] [PATCH 03/11] env_mmc.c: Allow environment to be used within SPL Tom Rini
2013-09-26 20:28 ` [U-Boot] [PATCH 04/11] mtd: Add a CONFIG_SPL_MTD_SUPPORT for a more full NAND subsystem in SPL Tom Rini
2013-09-26 20:39 ` Scott Wood
2013-09-26 20:28 ` [U-Boot] [PATCH 05/11] mtd: Build nand_util.o for CONFIG_ENV_IS_IN_NAND " Tom Rini
2013-09-26 20:42 ` Scott Wood
2013-09-26 20:45 ` Tom Rini
2013-09-26 20:51 ` Scott Wood
2013-09-26 21:14 ` Tom Rini
2013-09-26 20:28 ` [U-Boot] [PATCH 06/11] spl: Make CONFIG_SPL_ENV_SUPPORT have to be set by all users of env " Tom Rini
2013-09-26 20:28 ` [U-Boot] [PATCH 07/11] am335x_evm: Make SPL_OS also check the boot_os variable for falcon mode Tom Rini
2013-09-26 20:28 ` [U-Boot] [PATCH 08/11] README: Add CONFIG_SPL_OS_BOOT to README Tom Rini
2013-09-26 20:28 ` [U-Boot] [PATCH 09/11] README.falcon: Document environment variables for falcon mode Tom Rini
2013-09-26 20:28 ` [U-Boot] [PATCH 10/11] a3m071: Make spl_start_uboot test like getenv_yesno does Tom Rini
2013-09-27 7:04 ` Stefan Roese
2013-09-26 20:28 ` [U-Boot] [PATCH 11/11] spl_mmc/CONFIG_SPL_OS_BOOT: Allow environment to determine what to boot Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131005200212.37582380A3C@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox