From: Gerhard Sittig <gsi@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [UBOOT][PATCHv4 3/6] driver: mtd: spi: Add memory mapped read support
Date: Sun, 6 Oct 2013 11:33:29 +0200 [thread overview]
Message-ID: <20131006093329.GL14747@book.gsilab.sittig.org> (raw)
In-Reply-To: <1380898293-13755-4-git-send-email-sourav.poddar@ti.com>
On Fri, Oct 04, 2013 at 20:21 +0530, Sourav Poddar wrote:
>
> diff --git a/drivers/mtd/spi/sf_ops.c b/drivers/mtd/spi/sf_ops.c
> index c009af5..bee4128 100644
> --- a/drivers/mtd/spi/sf_ops.c
> +++ b/drivers/mtd/spi/sf_ops.c
> @@ -269,7 +269,9 @@ int spi_flash_cmd_read_ops(struct spi_flash *flash, u32 offset,
>
> /* Handle memory-mapped SPI */
> if (flash->memory_map) {
> + spi_xfer(flash->spi, 0, NULL, NULL, SPI_XFER_MEM_MAP);
> memcpy(data, flash->memory_map + offset, len);
> + spi_xfer(flash->spi, 0, NULL, NULL, SPI_XFER_MEM_MAP);
> return 0;
> }
Feedback has been sent before, but I'm afraid the motivation
wasn't received appropriately.
Shouldn't the memcpy() call be surrounded by _MAP and _MAP_END
(please note the _END in the second spi_xfer() invocation)? The
current patch doesn't "close" the transfer, which appears to pass
tests but isn't correct.
virtually yours
Gerhard Sittig
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
next prev parent reply other threads:[~2013-10-06 9:33 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 14:51 [U-Boot] [UBOOT][PATCHv4 0/6] Add TI qspi controller with memory mapped support Sourav Poddar
2013-10-04 14:51 ` [U-Boot] [UBOOT][PATCHv4 1/6] omap5: add qspi support Sourav Poddar
2013-10-04 14:51 ` [U-Boot] [UBOOT][PATCHv4 2/6] armv7: hw_data: change clock divider setting Sourav Poddar
2013-10-04 14:51 ` [U-Boot] [UBOOT][PATCHv4 3/6] driver: mtd: spi: Add memory mapped read support Sourav Poddar
2013-10-04 20:06 ` Jagan Teki
2013-10-05 6:12 ` Sourav Poddar
2013-10-06 9:33 ` Gerhard Sittig [this message]
2013-10-06 10:01 ` Sourav Poddar
2013-10-04 14:51 ` [U-Boot] [UBOOT][PATCHv4 4/6] spi: add TI QSPI driver Sourav Poddar
2013-10-04 18:57 ` Jagan Teki
2013-10-04 20:02 ` Sourav Poddar
2013-10-04 20:13 ` Jagan Teki
2013-10-05 6:08 ` Sourav Poddar
2013-10-05 9:41 ` Jagan Teki
2013-10-05 9:55 ` Sourav Poddar
2013-10-05 11:40 ` Jagan Teki
2013-10-05 14:23 ` Sourav Poddar
2013-10-06 8:44 ` Jagan Teki
2013-10-06 10:14 ` Sourav Poddar
2013-10-06 15:30 ` Jagan Teki
2013-10-06 15:51 ` Sourav Poddar
2013-10-04 14:51 ` [U-Boot] [UBOOT][PATCHv4 5/6] dra7xx_evm: add SPL API, QSPI, and serial flash support Sourav Poddar
2013-10-04 14:51 ` [U-Boot] [UBOOT][PATCHv4 6/6] README: qspi usecase and testing documentation Sourav Poddar
2013-10-04 18:38 ` Jagan Teki
2013-10-04 19:45 ` Sourav Poddar
2013-10-04 20:14 ` Jagan Teki
2013-10-05 6:08 ` Sourav Poddar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131006093329.GL14747@book.gsilab.sittig.org \
--to=gsi@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox