From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Sun, 6 Oct 2013 16:40:46 -0400 Subject: [U-Boot] [PATCH 02/11] env_mmc.c: Make the non-redundant env_relocate_spec use malloc not stack In-Reply-To: <20131005200013.D5132380A3C@gemini.denx.de> References: <1380227287-26057-1-git-send-email-trini@ti.com> <1380227287-26057-3-git-send-email-trini@ti.com> <20131005200013.D5132380A3C@gemini.denx.de> Message-ID: <20131006204046.GN15917@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sat, Oct 05, 2013 at 10:00:13PM +0200, Wolfgang Denk wrote: > Dear Tom Rini, > > In message <1380227287-26057-3-git-send-email-trini@ti.com> you wrote: > > Switch the case of non-redundant non-embedded environment to use malloc > > to allocate buffers, rather than place them on the stack, like the > > redundant case does. > > What exactly would be the benefit of this change? It just adds code > size and execution time and makes the code more complex, without any > appearent advanteages? The main advantage is that we can use this code in environments with less than CONFIG_ENV_SIZE worth of stack available. Arguably it makes the behaviour and code paths similar for redundant and non-redundant cases (but someone posted a patch to make the redundant case use the stack). -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: