From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Sun, 6 Oct 2013 16:55:27 -0400 Subject: [U-Boot] [PATCH 01/11] fw_env.c: Increase max dev path to 32 In-Reply-To: <20131005200212.37582380A3C@gemini.denx.de> References: <1380227287-26057-1-git-send-email-trini@ti.com> <1380227287-26057-2-git-send-email-trini@ti.com> <20131005200212.37582380A3C@gemini.denx.de> Message-ID: <20131006205527.GP15917@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sat, Oct 05, 2013 at 10:02:12PM +0200, Wolfgang Denk wrote: > Dear Tom Rini, > > In message <1380227287-26057-2-git-send-email-trini@ti.com> you wrote: > > Currently our limit is too small to allow for /dev/mmcblk0boot0 to work, > > for example. Expand to 32 for future needs. > > > > Signed-off-by: Tom Rini > > --- > > tools/env/fw_env.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c > > index 577ce2d..bf5c552 100644 > > --- a/tools/env/fw_env.c > > +++ b/tools/env/fw_env.c > > @@ -40,7 +40,7 @@ > > _min1 < _min2 ? _min1 : _min2; }) > > > > struct envdev_s { > > - char devname[16]; /* Device name */ > > + char devname[32]; /* Device name */ > > Do we really need a static size here? Can we not auto-adjust to the > needed size, say by dynamically allocating the buffer? Doesn't look like it, without a big change to the parsing code. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: