From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] env_mmc: fix buffer allocation for armv7
Date: Tue, 08 Oct 2013 20:17:01 +0200 [thread overview]
Message-ID: <20131008181701.C8181381188@gemini.denx.de> (raw)
In-Reply-To: <20131008134456.GB15917@bill-the-cat>
Dear Tom,
In message <20131008134456.GB15917@bill-the-cat> you wrote:
>
> > Well, if we have DDR such that we can use it for the malloc arena, we
> > also should use it for the stack. Or is there a good reason for not
> > doing this? It would solve all these issues at the root...
>
> Making SPL more complex for everyone? We would need to do a fairly
> good-sized re-jigger of SPL to setup and swap around stack pointers like
> we do in full U-Boot.
Hm, I'm not convinced. As proposed, we make the code bigger, less
efficient, more error prone and more ugly for everyone, not only for
SPL users. Aslo, this might not be the only place where buffers or
such may be kept on the stack. I hope you don't want to change all
these?
Really, if we have the resources, we should use them. If RAM is
abailable, it should also be used for the stack. Just using it for
malloc() is neither fish nor fowl.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Have you lived in this village all your life?" "No, not yet."
next prev parent reply other threads:[~2013-10-08 18:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 13:48 [U-Boot] [PATCH] env_mmc: fix buffer allocation for armv7 Markus Niebel
2013-10-04 17:02 ` Tom Rini
2013-10-05 19:57 ` Wolfgang Denk
2013-10-06 20:42 ` Tom Rini
2013-10-07 5:34 ` Wolfgang Denk
2013-10-07 12:20 ` Tom Rini
2013-10-07 13:58 ` Wolfgang Denk
2013-10-08 13:44 ` Tom Rini
2013-10-08 18:17 ` Wolfgang Denk [this message]
2013-10-11 18:27 ` Tom Rini
2013-10-07 7:58 ` Markus Niebel
2013-10-14 20:26 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131008181701.C8181381188@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox