From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] Coding Style cleanup: replace leading SPACEs by TABs
Date: Wed, 9 Oct 2013 11:39:14 -0400 [thread overview]
Message-ID: <20131009153914.GJ15917@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ1+Us+0-vxtgmWUw=VU-my52zQs583bAq_iCqZfqR4oAQ@mail.gmail.com>
On Wed, Oct 09, 2013 at 09:33:53AM -0600, Simon Glass wrote:
> Hi Tom,
>
> On Wed, Oct 9, 2013 at 9:29 AM, Tom Rini <trini@ti.com> wrote:
>
> > On Wed, Oct 09, 2013 at 08:02:10PM +0900, Masahiro Yamada wrote:
> > > Hello, Wolfgang, Simon.
> > >
> > > (I added Cc Simon)
> > >
> > >
> > > > tools/buildman/README | 268 +--
> > > > tools/buildman/board.py | 236 +-
> > > > tools/buildman/bsettings.py | 18 +-
> > > > tools/buildman/builder.py | 2374
> > ++++++++++----------
> > > > tools/buildman/buildman.py | 16 +-
> > > > tools/buildman/control.py | 136 +-
> > > > tools/buildman/test.py | 162 +-
> > > > tools/buildman/toolchain.py | 392 ++--
> > >
> > > I might be too worried, but so many lines are going to be changed.
> > > Just in case, I hope Simon checks this.
> >
> > I'm not sure whacking the whitespace in quasi-external (I know patman is
> > used outside U-Boot, I forget about buildman) python tools is the right
> > way to go here. Today the tools are consistent and space-only. This
> > makes it mix-and-match.
>
> patman also. The coding style I tried to follow for Python is PEP 8 - with
> spaces. At least it is consistent.
OK, yeah. Wolfgang, please drop patman/buildman and
test/image/test-fit.py changes out of this. reformat.py is consistently
using tabs, except for what you fixed, so that's fine.
If that's still a problem, we need to reformat the whole of the tool to
something tab-consistent instead, entirely. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131009/4c42c759/attachment.pgp>
next prev parent reply other threads:[~2013-10-09 15:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 15:43 [U-Boot] [PATCH 0/4] Coding Style cleanup Wolfgang Denk
2013-10-04 15:43 ` [U-Boot] [PATCH 1/4] Coding Style cleanup: remove trailing white space Wolfgang Denk
2013-10-07 6:05 ` Michal Simek
2013-10-07 10:52 ` Wolfgang Denk
2013-10-07 11:07 ` [U-Boot] [PATCH 1/4 V2] " Wolfgang Denk
2013-10-14 20:26 ` [U-Boot] [U-Boot, 1/4, " Tom Rini
2013-10-04 15:43 ` [U-Boot] [PATCH 2/4] Coding Style cleanup: replace leading SPACEs by TABs Wolfgang Denk
2013-10-09 11:02 ` Masahiro Yamada
2013-10-09 15:29 ` Tom Rini
2013-10-09 15:33 ` Simon Glass
2013-10-09 15:39 ` Tom Rini [this message]
2013-10-14 20:26 ` [U-Boot] [U-Boot, " Tom Rini
2013-10-04 15:43 ` [U-Boot] [PATCH 3/4] Coding Style cleanup: remove trailing empty lines Wolfgang Denk
2013-10-14 20:27 ` [U-Boot] [U-Boot, " Tom Rini
2013-10-04 15:43 ` [U-Boot] [PATCH 4/4] Coding Style cleanup: drop some excessive " Wolfgang Denk
2013-10-14 20:27 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131009153914.GJ15917@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox