* [U-Boot] [Patch v1 1/1] usb:smsx95xx LED activity for USB net driver
@ 2013-10-08 3:30 Suriyan Ramasami
2013-10-08 14:37 ` Simon Glass
0 siblings, 1 reply; 5+ messages in thread
From: Suriyan Ramasami @ 2013-10-08 3:30 UTC (permalink / raw)
To: u-boot
Add LED activity for SMSX95XX USB Ether driver.
Signed-off-by: ?Suriyan Ramasami" <suriyan.r@gmail.com>
---
drivers/usb/eth/smsc95xx.c | 14 ++++++++++++++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/eth/smsc95xx.c b/drivers/usb/eth/smsc95xx.c
index 15fd9a9..7bf0a34 100644
--- a/drivers/usb/eth/smsc95xx.c
+++ b/drivers/usb/eth/smsc95xx.c
@@ -14,6 +14,12 @@
/* SMSC LAN95xx based USB 2.0 Ethernet Devices */
+/* LED defines */
+#define LED_GPIO_CFG (0x24)
+#define LED_GPIO_CFG_SPD_LED (0x01000000)
+#define LED_GPIO_CFG_LNK_LED (0x00100000)
+#define LED_GPIO_CFG_FDX_LED (0x00010000)
+
/* Tx command words */
#define TX_CMD_A_FIRST_SEG_ 0x00002000
#define TX_CMD_A_LAST_SEG_ 0x00001000
@@ -591,6 +597,14 @@ static int smsc95xx_init(struct eth_device *eth, bd_t *bd)
return ret;
debug("ID_REV = 0x%08x\n", read_buf);
+ /* Configure GPIO pins as LED outputs */
+ write_buf = LED_GPIO_CFG_SPD_LED | LED_GPIO_CFG_LNK_LED |
+ LED_GPIO_CFG_FDX_LED;
+ ret = smsc95xx_write_reg(dev, LED_GPIO_CFG, write_buf);
+ if (ret < 0)
+ return ret;
+ debug("LED_GPIO_CFG set\n");
+
/* Init Tx */
write_buf = 0;
ret = smsc95xx_write_reg(dev, FLOW, write_buf);
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [Patch v1 1/1] usb:smsx95xx LED activity for USB net driver
2013-10-08 3:30 [U-Boot] [Patch v1 1/1] usb:smsx95xx LED activity for USB net driver Suriyan Ramasami
@ 2013-10-08 14:37 ` Simon Glass
2013-10-10 0:39 ` Marek Vasut
0 siblings, 1 reply; 5+ messages in thread
From: Simon Glass @ 2013-10-08 14:37 UTC (permalink / raw)
To: u-boot
+Joe (net maintainer)
+Marek (USB)
Hi Suriyan,
On Mon, Oct 7, 2013 at 9:30 PM, Suriyan Ramasami <suriyan.r@gmail.com>wrote:
> Add LED activity for SMSX95XX USB Ether driver.
>
> Signed-off-by: ?Suriyan Ramasami" <suriyan.r@gmail.com>
> ---
> drivers/usb/eth/smsc95xx.c | 14 ++++++++++++++
> 1 files changed, 14 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/eth/smsc95xx.c b/drivers/usb/eth/smsc95xx.c
> index 15fd9a9..7bf0a34 100644
> --- a/drivers/usb/eth/smsc95xx.c
> +++ b/drivers/usb/eth/smsc95xx.c
> @@ -14,6 +14,12 @@
>
> /* SMSC LAN95xx based USB 2.0 Ethernet Devices */
>
> +/* LED defines */
> +#define LED_GPIO_CFG (0x24)
> +#define LED_GPIO_CFG_SPD_LED (0x01000000)
> +#define LED_GPIO_CFG_LNK_LED (0x00100000)
> +#define LED_GPIO_CFG_FDX_LED (0x00010000)
> +
> /* Tx command words */
> #define TX_CMD_A_FIRST_SEG_ 0x00002000
> #define TX_CMD_A_LAST_SEG_ 0x00001000
> @@ -591,6 +597,14 @@ static int smsc95xx_init(struct eth_device *eth, bd_t
> *bd)
> return ret;
> debug("ID_REV = 0x%08x\n", read_buf);
>
> + /* Configure GPIO pins as LED outputs */
> + write_buf = LED_GPIO_CFG_SPD_LED | LED_GPIO_CFG_LNK_LED |
> + LED_GPIO_CFG_FDX_LED;
> + ret = smsc95xx_write_reg(dev, LED_GPIO_CFG, write_buf);
> + if (ret < 0)
> + return ret;
> + debug("LED_GPIO_CFG set\n");
> +
>
Seems good.
Acked-by: Simon Glass <sjg@chromium.org>
> /* Init Tx */
> write_buf = 0;
> ret = smsc95xx_write_reg(dev, FLOW, write_buf);
> --
> 1.7.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [Patch v1 1/1] usb:smsx95xx LED activity for USB net driver
2013-10-08 14:37 ` Simon Glass
@ 2013-10-10 0:39 ` Marek Vasut
2013-10-10 0:40 ` Joe Hershberger
0 siblings, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2013-10-10 0:39 UTC (permalink / raw)
To: u-boot
Dear Simon Glass,
> +Joe (net maintainer)
> +Marek (USB)
>
> Hi Suriyan,
>
> On Mon, Oct 7, 2013 at 9:30 PM, Suriyan Ramasami <suriyan.r@gmail.com>wrote:
> > Add LED activity for SMSX95XX USB Ether driver.
> >
> > Signed-off-by: ?Suriyan Ramasami" <suriyan.r@gmail.com>
> > ---
> >
> > drivers/usb/eth/smsc95xx.c | 14 ++++++++++++++
> > 1 files changed, 14 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/usb/eth/smsc95xx.c b/drivers/usb/eth/smsc95xx.c
> > index 15fd9a9..7bf0a34 100644
> > --- a/drivers/usb/eth/smsc95xx.c
> > +++ b/drivers/usb/eth/smsc95xx.c
> > @@ -14,6 +14,12 @@
> >
> > /* SMSC LAN95xx based USB 2.0 Ethernet Devices */
> >
> > +/* LED defines */
> > +#define LED_GPIO_CFG (0x24)
> > +#define LED_GPIO_CFG_SPD_LED (0x01000000)
> > +#define LED_GPIO_CFG_LNK_LED (0x00100000)
> > +#define LED_GPIO_CFG_FDX_LED (0x00010000)
> > +
> >
> > /* Tx command words */
> > #define TX_CMD_A_FIRST_SEG_ 0x00002000
> > #define TX_CMD_A_LAST_SEG_ 0x00001000
> >
> > @@ -591,6 +597,14 @@ static int smsc95xx_init(struct eth_device *eth,
> > bd_t *bd)
> >
> > return ret;
> >
> > debug("ID_REV = 0x%08x\n", read_buf);
> >
> > + /* Configure GPIO pins as LED outputs */
> > + write_buf = LED_GPIO_CFG_SPD_LED | LED_GPIO_CFG_LNK_LED |
> > + LED_GPIO_CFG_FDX_LED;
> > + ret = smsc95xx_write_reg(dev, LED_GPIO_CFG, write_buf);
> > + if (ret < 0)
> > + return ret;
> > + debug("LED_GPIO_CFG set\n");
> > +
>
> Seems good.
>
> Acked-by: Simon Glass <sjg@chromium.org>
Applied to usb/next
I kinda wonder if Joe shouldn't pick this one. Is Joe still active ?
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [Patch v1 1/1] usb:smsx95xx LED activity for USB net driver
2013-10-10 0:39 ` Marek Vasut
@ 2013-10-10 0:40 ` Joe Hershberger
2013-10-10 0:42 ` Marek Vasut
0 siblings, 1 reply; 5+ messages in thread
From: Joe Hershberger @ 2013-10-10 0:40 UTC (permalink / raw)
To: u-boot
On Oct 9, 2013, at 6:39 PM, Marek Vasut <marex@denx.de> wrote:
> Dear Simon Glass,
>
>> +Joe (net maintainer)
>> +Marek (USB)
>>
>> Hi Suriyan,
>>
>> On Mon, Oct 7, 2013 at 9:30 PM, Suriyan Ramasami <suriyan.r@gmail.com>wrote:
>>> Add LED activity for SMSX95XX USB Ether driver.
>>>
>>> Signed-off-by: ?Suriyan Ramasami" <suriyan.r@gmail.com>
>>> ---
>>>
>>> drivers/usb/eth/smsc95xx.c | 14 ++++++++++++++
>>> 1 files changed, 14 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/usb/eth/smsc95xx.c b/drivers/usb/eth/smsc95xx.c
>>> index 15fd9a9..7bf0a34 100644
>>> --- a/drivers/usb/eth/smsc95xx.c
>>> +++ b/drivers/usb/eth/smsc95xx.c
>>> @@ -14,6 +14,12 @@
>>>
>>> /* SMSC LAN95xx based USB 2.0 Ethernet Devices */
>>>
>>> +/* LED defines */
>>> +#define LED_GPIO_CFG (0x24)
>>> +#define LED_GPIO_CFG_SPD_LED (0x01000000)
>>> +#define LED_GPIO_CFG_LNK_LED (0x00100000)
>>> +#define LED_GPIO_CFG_FDX_LED (0x00010000)
>>> +
>>>
>>> /* Tx command words */
>>> #define TX_CMD_A_FIRST_SEG_ 0x00002000
>>> #define TX_CMD_A_LAST_SEG_ 0x00001000
>>>
>>> @@ -591,6 +597,14 @@ static int smsc95xx_init(struct eth_device *eth,
>>> bd_t *bd)
>>>
>>> return ret;
>>>
>>> debug("ID_REV = 0x%08x\n", read_buf);
>>>
>>> + /* Configure GPIO pins as LED outputs */
>>> + write_buf = LED_GPIO_CFG_SPD_LED | LED_GPIO_CFG_LNK_LED |
>>> + LED_GPIO_CFG_FDX_LED;
>>> + ret = smsc95xx_write_reg(dev, LED_GPIO_CFG, write_buf);
>>> + if (ret < 0)
>>> + return ret;
>>> + debug("LED_GPIO_CFG set\n");
>>> +
>>
>> Seems good.
>>
>> Acked-by: Simon Glass <sjg@chromium.org>
>
> Applied to usb/next
>
> I kinda wonder if Joe shouldn't pick this one. Is Joe still active ?
Sure... When I need to be.
>
> Best regards,
> Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [Patch v1 1/1] usb:smsx95xx LED activity for USB net driver
2013-10-10 0:40 ` Joe Hershberger
@ 2013-10-10 0:42 ` Marek Vasut
0 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2013-10-10 0:42 UTC (permalink / raw)
To: u-boot
Dear Joe Hershberger,
> On Oct 9, 2013, at 6:39 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Simon Glass,
> >
> >> +Joe (net maintainer)
> >> +Marek (USB)
> >>
> >> Hi Suriyan,
> >>
> >> On Mon, Oct 7, 2013 at 9:30 PM, Suriyan Ramasami
<suriyan.r@gmail.com>wrote:
> >>> Add LED activity for SMSX95XX USB Ether driver.
> >>>
> >>> Signed-off-by: ?Suriyan Ramasami" <suriyan.r@gmail.com>
> >>> ---
> >>>
> >>> drivers/usb/eth/smsc95xx.c | 14 ++++++++++++++
> >>> 1 files changed, 14 insertions(+), 0 deletions(-)
> >>>
> >>> diff --git a/drivers/usb/eth/smsc95xx.c b/drivers/usb/eth/smsc95xx.c
> >>> index 15fd9a9..7bf0a34 100644
> >>> --- a/drivers/usb/eth/smsc95xx.c
> >>> +++ b/drivers/usb/eth/smsc95xx.c
> >>> @@ -14,6 +14,12 @@
> >>>
> >>> /* SMSC LAN95xx based USB 2.0 Ethernet Devices */
> >>>
> >>> +/* LED defines */
> >>> +#define LED_GPIO_CFG (0x24)
> >>> +#define LED_GPIO_CFG_SPD_LED (0x01000000)
> >>> +#define LED_GPIO_CFG_LNK_LED (0x00100000)
> >>> +#define LED_GPIO_CFG_FDX_LED (0x00010000)
> >>> +
> >>>
> >>> /* Tx command words */
> >>> #define TX_CMD_A_FIRST_SEG_ 0x00002000
> >>> #define TX_CMD_A_LAST_SEG_ 0x00001000
> >>>
> >>> @@ -591,6 +597,14 @@ static int smsc95xx_init(struct eth_device *eth,
> >>> bd_t *bd)
> >>>
> >>> return ret;
> >>>
> >>> debug("ID_REV = 0x%08x\n", read_buf);
> >>>
> >>> + /* Configure GPIO pins as LED outputs */
> >>> + write_buf = LED_GPIO_CFG_SPD_LED | LED_GPIO_CFG_LNK_LED |
> >>> + LED_GPIO_CFG_FDX_LED;
> >>> + ret = smsc95xx_write_reg(dev, LED_GPIO_CFG, write_buf);
> >>> + if (ret < 0)
> >>> + return ret;
> >>> + debug("LED_GPIO_CFG set\n");
> >>> +
> >>
> >> Seems good.
> >>
> >> Acked-by: Simon Glass <sjg@chromium.org>
> >
> > Applied to usb/next
> >
> > I kinda wonder if Joe shouldn't pick this one. Is Joe still active ?
>
> Sure... When I need to be.
Heh :) Haven't seen you on IRC for a while (and you surely missed a lot, applied
for sjg too). I picked this patch, so no problem here.
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-10-10 0:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-08 3:30 [U-Boot] [Patch v1 1/1] usb:smsx95xx LED activity for USB net driver Suriyan Ramasami
2013-10-08 14:37 ` Simon Glass
2013-10-10 0:39 ` Marek Vasut
2013-10-10 0:40 ` Joe Hershberger
2013-10-10 0:42 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox