From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] lcd: add DataImage SCF0403x LCD panel support
Date: Thu, 10 Oct 2013 18:57:08 +0200 [thread overview]
Message-ID: <20131010185708.2d3bd9b4@crub> (raw)
In-Reply-To: <1381329965-7775-3-git-send-email-nikita@compulab.co.il>
On Wed, 9 Oct 2013 17:46:04 +0300
Nikita Kiryanov <nikita@compulab.co.il> wrote:
...
> diff --git a/drivers/video/scf0403_lcd.c b/drivers/video/scf0403_lcd.c
> new file mode 100644
> index 0000000..1d1c3ff
> --- /dev/null
> +++ b/drivers/video/scf0403_lcd.c
> @@ -0,0 +1,298 @@
> +/*
> + * scf0403.c -- support for DataImage SCF0403 LCD
> + *
> + * Copyright (c) 2013 Adapted from Linux driver:
> + * Copyright (c) 2012 Anders Electronics plc. All Rights Reserved.
> + * Copyright (c) 2012 CompuLab, Ltd
> + * Dmitry Lifshitz <lifshitz@compulab.co.il>
> + * Ilya Ledvich <ilya@compulab.co.il>
> + * Inspired by Alberto Panizzo <maramaopercheseimorto@gmail.com> &
> + * Marek Vasut work in l4f00242t03.c
> + *
> + * U-Boot port: Nikita Kiryanov <nikita@compulab.co.il>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
please use "SPDX-License-Identifier: GPL-2.0" here.
See Licenses/README for more info.
...
> + for (i = 0; i < priv->seq_size; i++) {
> + if (scf0403_spi_transfer(priv->spi, &priv->init_seq[i].cmd) < 0)
> + printf("SPI transfer failed\n");
using puts() for not formatted strings is preferred, please
check in other places, too.
> +++ b/include/scf0403_lcd.h
> @@ -0,0 +1,22 @@
...
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc.
also please use SPDX license identifier here, too.
Thanks,
Anatolij
next prev parent reply other threads:[~2013-10-10 16:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 14:46 [U-Boot] [PATCH 0/3] Add support for SPI based DataImage LCD panel Nikita Kiryanov
2013-10-09 14:46 ` [U-Boot] [PATCH 1/3] spi: omap3: add support for more word lengths Nikita Kiryanov
2013-10-10 15:26 ` Gerhard Sittig
2013-10-14 14:18 ` Igor Grinberg
2013-10-15 11:09 ` Nikita Kiryanov
2013-10-09 14:46 ` [U-Boot] [PATCH 2/3] lcd: add DataImage SCF0403x LCD panel support Nikita Kiryanov
2013-10-10 16:57 ` Anatolij Gustschin [this message]
2013-10-14 14:34 ` Igor Grinberg
2013-10-09 14:46 ` [U-Boot] [PATCH 3/3] cm_t35: use scf0403 driver Nikita Kiryanov
2013-10-10 17:01 ` Anatolij Gustschin
2013-10-15 6:38 ` Igor Grinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131010185708.2d3bd9b4@crub \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox