From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] env_mmc: fix buffer allocation for armv7
Date: Fri, 11 Oct 2013 14:27:24 -0400 [thread overview]
Message-ID: <20131011182724.GP15917@bill-the-cat> (raw)
In-Reply-To: <20131008181701.C8181381188@gemini.denx.de>
On Tue, Oct 08, 2013 at 08:17:01PM +0200, Wolfgang Denk wrote:
> Dear Tom,
>
> In message <20131008134456.GB15917@bill-the-cat> you wrote:
> >
> > > Well, if we have DDR such that we can use it for the malloc arena, we
> > > also should use it for the stack. Or is there a good reason for not
> > > doing this? It would solve all these issues at the root...
> >
> > Making SPL more complex for everyone? We would need to do a fairly
> > good-sized re-jigger of SPL to setup and swap around stack pointers like
> > we do in full U-Boot.
>
> Hm, I'm not convinced. As proposed, we make the code bigger, less
> efficient, more error prone and more ugly for everyone, not only for
> SPL users. Aslo, this might not be the only place where buffers or
> such may be kept on the stack. I hope you don't want to change all
> these?
>
> Really, if we have the resources, we should use them. If RAM is
> abailable, it should also be used for the stack. Just using it for
> malloc() is neither fish nor fowl.
I'll ceed the point and re-work things on my series then. Markus, your
patch is good as-is and I shall pick it up shortly.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131011/1b527155/attachment.pgp>
next prev parent reply other threads:[~2013-10-11 18:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 13:48 [U-Boot] [PATCH] env_mmc: fix buffer allocation for armv7 Markus Niebel
2013-10-04 17:02 ` Tom Rini
2013-10-05 19:57 ` Wolfgang Denk
2013-10-06 20:42 ` Tom Rini
2013-10-07 5:34 ` Wolfgang Denk
2013-10-07 12:20 ` Tom Rini
2013-10-07 13:58 ` Wolfgang Denk
2013-10-08 13:44 ` Tom Rini
2013-10-08 18:17 ` Wolfgang Denk
2013-10-11 18:27 ` Tom Rini [this message]
2013-10-07 7:58 ` Markus Niebel
2013-10-14 20:26 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131011182724.GP15917@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox