From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Sun, 13 Oct 2013 22:50:49 +0200
Subject: [U-Boot] [RFC PATCH] usb: dfu: make nand upload working
In-Reply-To: <20131012231914.0e4516f9@jawa>
References: <1381564034-5935-1-git-send-email-voice.shen@atmel.com>
	<20131012231914.0e4516f9@jawa>
Message-ID: <201310132250.50029.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Lukasz Majewski,

> On Sat, 12 Oct 2013 15:47:14 +0800
> 
> Bo Shen <voice.shen@atmel.com> wrote:
> > If won't pass value to dfu->r_left, it always 0, make no transfer,
> > the dfu-util on host side report failed. So, before starting transfer,
> > pass the value, then nand uploading can work.
> > 
> > Signed-off-by: Bo Shen <voice.shen@atmel.com>
> > 
> > ---
> > 
> >  drivers/dfu/dfu.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c
> > index 56b21c7..3c3ad1b 100644
> > --- a/drivers/dfu/dfu.c
> > +++ b/drivers/dfu/dfu.c
> > @@ -274,6 +274,7 @@ int dfu_read(struct dfu_entity *dfu, void *buf,
> > int size, int blk_seq_num) if (dfu->i_buf_start == NULL)
> > 
> >  			return -ENOMEM;
> > 
> > +		dfu->r_left = dfu->data.nand.size;
> 
> Please do not add nand related code to "generic" DFU code. This can
> damage DFU operation with other memories (like eMMC).
> 
> Such code shall be added to dfu_nand.c file.
> 

ACK, waiting for V2.

Lukasz, do you have a suggestion where this should be placed and why is this an 
actual issue?

Best regards,
Marek Vasut