From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Mon, 14 Oct 2013 18:04:47 +0200
Subject: [U-Boot] fatls shows duplicated entries with long and short
	names
In-Reply-To: <525C1514.5030307@digi.com>
References: <525C1514.5030307@digi.com>
Message-ID: <201310141804.47741.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Hector Palacios,

> Dear Marek,
> 
> I noticed that 'fatls' displays duplicated filenames (short and long) for
> every file in the media:
> 
> # fatls mmc 0
>    2083460   uimage-myplatform
>    2083460   uimage~1
>       1520   rootfs-dummy.jffs2
>       1520   rootfs~1.jff
>    3294952   uimage
>    3294952   uimage
> 
> The guilty commit is ff04f6d1224d8952b566b8671222151495883073 by you, who
> moved the chksum calculation out of an if() and now the code never enters
> this:
> 
> #ifdef CONFIG_SUPPORT_VFAT
> 			else if (dols == LS_ROOT && csum == prevcksum) {
> 				prevcksum = 0xffff;
> 				dentptr++;
> 				continue;
> 			}
> #endif
> 
> Could you please check?

CCing Tom.

Best regards,
Marek Vasut