From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3 v2] exynos: i2c: Fix i2c driver to handle NACKs properly
Date: Tue, 15 Oct 2013 08:34:17 +0200 [thread overview]
Message-ID: <20131015083417.569679a4@amdc308.digital.local> (raw)
In-Reply-To: <525CCE3B.3070109@denx.de>
Hi Heiko,
> Hello Naveen,
>
> Am 15.10.2013 06:48, schrieb Naveen Krishna Ch:
> > On 14 October 2013 11:59, Heiko Schocher<hs@denx.de> wrote:
> >> Hello Naveen,
> >>
> >> Am 03.10.2013 13:22, schrieb Naveen Krishna Chatradhi:
> >>
> >>> The Exynos5 i2c driver does not handle NACKs properly. This
> >>> change:
> >>>
> >>> - fixes the NACK processing problem (do not continue transaction
> >>> if address cycle was NACKed)
> >>>
> >>> - eliminates a fair amount of duplicate code
> >>>
> >>> Signed-off-by: Vadim Bendebury<vbendeb@chromium.org>
> >>> Reviewed-by: Simon Glass<sjg@google.com>
> >>> Signed-off-by: Naveen Krishna Chatradhi<ch.naveen@samsung.com>
> >>> ---
> >>> Changes since v1:
> >>> 1. Removed the compilation error mentioned by Heiko for VCMA9
> >>> board...
> >>
> >>
> >> Hmm.. just tried your patchset and I get for the VCMA9 board:
> >>
> >> http://patchwork.ozlabs.org/patch/280286/
> >> http://patchwork.ozlabs.org/patch/280287/
> >> http://patchwork.ozlabs.org/patch/280288/
> >>
> >>
> >> Configuring for VCMA9 board...
> >> s3c24x0_i2c.c:125:39: error: 'CONFIG_MAX_I2C_NUM' undeclared here
> >> (not in a function)
> >> arm-linux-gnueabi-size: './u-boot': No such file
> >> s3c24x0_i2c.c:125:39: error: 'CONFIG_MAX_I2C_NUM' undeclared here
> >> (not in a function)
> >> s3c24x0_i2c.c:125:31: warning: 'i2c_bus' defined but not used
> >> [-Wunused-variable]
> >> s3c24x0_i2c.c:295:12: warning: 'hsi2c_get_clk_details' defined but
> >> not used [-Wunused-function]
> >> make[1]: *** [s3c24x0_i2c.o] Fehler 1
> >> make: *** [drivers/i2c/libi2c.o] Fehler 2
> >> make: *** Warte auf noch nicht beendete Prozesse...
> >>
> >> Could you check this complete patchset, thanks!
> > Just check with "make VCMA9 -j4> err" I see the errors.
> > Heiko, Whats the best way to check the compilation errors for all
> > boards related to Samsung.
>
> in U-Boot tree:
>
> all s3c24x0 boards:
> ./MAKEALL -s s3c24x0
Also you can try:
./MAKEALL -v samsung
>
> (prefered check) all arm boards:
> ./MAKEALL arm
>
> > Will resubmit the patchset.
>
> Thanks!
>
> bye,
> Heiko
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
next prev parent reply other threads:[~2013-10-15 6:34 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 10:58 [U-Boot] [PATCH] i2c: s3c24xx: add hsi2c controller support Naveen Krishna Chatradhi
2013-03-12 13:11 ` Simon Glass
2013-03-12 14:03 ` Naveen Krishna Ch
2013-04-06 1:37 ` [U-Boot] [PATCH v4] " Naveen Krishna Chatradhi
2013-04-13 4:42 ` Naveen Krishna Ch
2013-04-15 5:48 ` Heiko Schocher
2013-04-15 12:48 ` Tom Rini
2013-04-26 3:08 ` Naveen Krishna Ch
2013-04-29 6:36 ` Minkyu Kang
2013-04-30 4:14 ` Heiko Schocher
2013-05-01 19:04 ` Naveen Krishna Ch
2013-05-02 10:06 ` Heiko Schocher
2013-05-02 17:52 ` Naveen Krishna Ch
2013-09-30 6:58 ` [U-Boot] [PATCH 0/3] i2c: improve s3c24x0 with High-speed and new SYS_I2C framework support Naveen Krishna Chatradhi
2013-09-30 6:58 ` [U-Boot] [PATCH 1/4] exynos: i2c: Fix i2c driver to handle NACKs properly Naveen Krishna Chatradhi
2013-10-02 13:51 ` Heiko Schocher
2013-09-30 6:58 ` [U-Boot] [PATCH 2/4] exynos: i2c: Change FDT bus setup code to enumerate ports correctly Naveen Krishna Chatradhi
2013-10-03 11:23 ` [U-Boot] [PATCH 2/3 v2] " Naveen Krishna Chatradhi
2013-10-15 10:32 ` [U-Boot] [PATCH 2/3 v4] " Naveen Krishna Chatradhi
2013-10-17 6:31 ` [U-Boot] [U-Boot, 2/3, " Heiko Schocher
2013-09-30 6:58 ` [U-Boot] [PATCH v5 3/4] i2c: s3c24xx: add hsi2c controller support Naveen Krishna Chatradhi
2013-09-30 6:58 ` [U-Boot] [PATCH] RFC: samsung: i2c: Enable new CONFIG_SYS_I2C framework Naveen Krishna Chatradhi
2013-10-14 6:06 ` Heiko Schocher
2013-11-08 7:45 ` Piotr Wilczek
2013-11-08 7:59 ` Naveen Krishna Ch
2013-11-20 10:50 ` [U-Boot] [PATCH 2/2 v2] " Naveen Krishna Chatradhi
2013-11-25 11:28 ` [U-Boot] [PATCH] i2c: samsung: register i2c busses for Exynso5420 and Exynos5250 Naveen Krishna Chatradhi
2013-11-25 11:31 ` Naveen Krishna Ch
2013-12-05 11:26 ` [U-Boot] " Heiko Schocher
2013-12-05 12:21 ` Naveen Krishna Ch
2013-12-05 12:47 ` Heiko Schocher
2013-12-06 5:47 ` Naveen Krishna Ch
2013-12-06 6:16 ` Heiko Schocher
2013-12-06 6:42 ` [U-Boot] [PATCH v2] " Naveen Krishna Chatradhi
2013-12-09 6:58 ` [U-Boot] [U-Boot, " Heiko Schocher
2013-09-30 8:05 ` [U-Boot] [PATCH 0/3] i2c: improve s3c24x0 with High-speed and new SYS_I2C framework support Heiko Schocher
2013-09-30 10:03 ` Naveen Krishna Ch
2013-10-01 6:05 ` Heiko Schocher
2013-10-01 6:19 ` Naveen Krishna Ch
2013-10-01 6:36 ` Heiko Schocher
2013-10-03 11:22 ` [U-Boot] [PATCH 1/3 v2] exynos: i2c: Fix i2c driver to handle NACKs properly Naveen Krishna Chatradhi
2013-10-14 6:29 ` Heiko Schocher
2013-10-15 4:48 ` Naveen Krishna Ch
2013-10-15 5:10 ` Heiko Schocher
2013-10-15 6:34 ` Lukasz Majewski [this message]
2013-10-15 10:31 ` [U-Boot] [PATCH 1/3 v4] " Naveen Krishna Chatradhi
2013-10-17 6:29 ` [U-Boot] [U-Boot, 1/3, " Heiko Schocher
2013-10-15 6:07 ` [U-Boot] [PATCH 1/3 v3] " Naveen Krishna Chatradhi
2013-10-15 6:07 ` [U-Boot] [PATCH 2/3 v3] exynos: i2c: Change FDT bus setup code to enumerate ports correctly Naveen Krishna Chatradhi
2013-10-15 6:07 ` [U-Boot] [PATCH 3/3 v6] i2c: s3c24xx: add hsi2c controller support Naveen Krishna Chatradhi
2013-10-15 6:40 ` Heiko Schocher
2013-10-15 9:34 ` Naveen Krishna Ch
2013-10-15 9:39 ` Heiko Schocher
2013-10-15 9:44 ` Naveen Krishna Ch
2013-10-03 11:24 ` [U-Boot] [PATCH 3/3 v2]: " Naveen Krishna Chatradhi
2013-10-15 10:32 ` [U-Boot] [PATCH 3/3 v7] " Naveen Krishna Chatradhi
2013-10-17 6:32 ` [U-Boot] [U-Boot, 3/3, " Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131015083417.569679a4@amdc308.digital.local \
--to=l.majewski@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox