public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] serial: mxs_auart: Staticize local functions
Date: Tue, 15 Oct 2013 15:44:50 +0200	[thread overview]
Message-ID: <201310151544.50390.marex@denx.de> (raw)
In-Reply-To: <1381805555.19936.10.camel@phoenix>

Dear Axel Lin,

> Staticize local functions in mxs_auart driver.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Acked-by: Marek Vasut <marex@denx.de>

Just curious, how did you find this? Did you lint the files with some tool?

> ---
>  drivers/serial/mxs_auart.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/serial/mxs_auart.c b/drivers/serial/mxs_auart.c
> index 7cfe5bc..fc0fa96 100644
> --- a/drivers/serial/mxs_auart.c
> +++ b/drivers/serial/mxs_auart.c
> @@ -40,7 +40,7 @@ static struct mxs_uartapp_regs
> *get_uartapp_registers(void) * Sets the baud rate and settings.
>   * The settings are: 8 data bits, no parit and 1 stop bit.
>   */
> -void mxs_auart_setbrg(void)
> +static void mxs_auart_setbrg(void)
>  {
>  	u32 div;
>  	u32 linectrl = 0;
> @@ -77,7 +77,7 @@ void mxs_auart_setbrg(void)
>  	writel(linectrl, &regs->hw_uartapp_linectrl);
>  }
> 
> -int mxs_auart_init(void)
> +static int mxs_auart_init(void)
>  {
>  	struct mxs_uartapp_regs *regs = get_uartapp_registers();
>  	/* Reset everything */
> @@ -99,7 +99,7 @@ int mxs_auart_init(void)
>  	return 0;
>  }
> 
> -void mxs_auart_putc(const char c)
> +static void mxs_auart_putc(const char c)
>  {
>  	struct mxs_uartapp_regs *regs = get_uartapp_registers();
>  	/* Wait in loop while the transmit FIFO is full */
> @@ -112,14 +112,14 @@ void mxs_auart_putc(const char c)
>  		mxs_auart_putc('\r');
>  }
> 
> -int mxs_auart_tstc(void)
> +static int mxs_auart_tstc(void)
>  {
>  	struct mxs_uartapp_regs *regs = get_uartapp_registers();
>  	/* Checks if receive FIFO is empty */
>  	return !(readl(&regs->hw_uartapp_stat) & UARTAPP_STAT_RXFE_MASK);
>  }
> 
> -int mxs_auart_getc(void)
> +static int mxs_auart_getc(void)
>  {
>  	struct mxs_uartapp_regs *regs = get_uartapp_registers();
>  	/* Wait until a character is available to read */

Best regards,
Marek Vasut

  reply	other threads:[~2013-10-15 13:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-15  2:52 [U-Boot] [PATCH] serial: mxs_auart: Staticize local functions Axel Lin
2013-10-15 13:44 ` Marek Vasut [this message]
2013-10-16  0:51   ` Axel Lin
2013-11-08 22:27 ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201310151544.50390.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox