public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] ARM: U-boot and 2 GiB of ram with get_ram_size only being long
Date: Thu, 17 Oct 2013 08:27:48 +0200	[thread overview]
Message-ID: <20131017082748.06618979@lilith> (raw)
In-Reply-To: <1381859853.7979.696.camel@snotra.buserror.net>

Hi Scott,

On Tue, 15 Oct 2013 12:57:33 -0500, Scott Wood
<scottwood@freescale.com> wrote:

> On Tue, 2013-10-15 at 09:12 +0200, Albert ARIBAUD wrote:
> > Hi Oliver,
> > 
> > On Mon, 07 Oct 2013 04:41:31 +0200, Oliver Schinagl
> > <oliver+list@schinagl.nl> wrote:
> > 
> > > Hey all,
> > > 
> > > Having not received any feed back at all, I went ahead and did the 
> > > changes anyway. Everything seems to run and work fine for sunxi and 
> > > prints proper sizes.
> > > 
> > > For the other boards, I tried to run a MAKEALL but there where so many 
> > > random other warnings I can't say for 100% certainty there where no 
> > > mistakes that crept in.
> > 
> > There cannot possibly be a single warning if you're working from an
> > official U-Boot repo, as warnings are considered failures and thus no
> > patch reaches u-boot/master if it causes a warning.
> 
> That might be the theory, but in practice this is simply false.
> Different toolchains produce different warnings, and not all patches
> always get test-built on every target (especially on obscure
> architectures).  And since it's false that no warnings exist, that means
> sometimes even when a patch is test-built, some newly introduced
> warnings get missed (I got an e-mail pointing out such an occurance just
> today).

You are correct that the same code may or may not emit warnings
depending on the toolchain, and that U-Boot's build system won't stop
building because of warnings.

However, when a new toolchain version causes such warnings, but they
are not 'random' in any case; they may be numerous though, if in some
source code used in a lot of boards.

In any case, if Oliver gets warnings, chances are we'll get them to
when applying his code, in which case it'll be rejected, or we'll see
them happening later if he's unsing a common toolchain in a new
version, or he's using an unusual toolchain.

> -Scott

Amicalement,
-- 
Albert.

  reply	other threads:[~2013-10-17  6:27 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-03 21:15 [U-Boot] [RFC] ARM: U-boot and 2 GiB of ram with get_ram_size only being long Oliver Schinagl
2013-10-07  2:41 ` Oliver Schinagl
2013-10-15  7:12   ` Albert ARIBAUD
2013-10-15 17:57     ` Scott Wood
2013-10-17  6:27       ` Albert ARIBAUD [this message]
2013-10-18  0:04         ` Oliver Schinagl
2013-10-18 16:43           ` Scott Wood
2013-10-18 20:26             ` Wolfgang Denk
2013-10-18 21:04               ` Scott Wood
2013-10-18 21:53                 ` Wolfgang Denk
2013-10-18 23:11               ` Oliver Schinagl
2013-10-18 23:07             ` Oliver Schinagl
2013-10-18 23:25               ` Scott Wood
2013-10-18 23:25                 ` Scott Wood
2013-10-19  9:21                   ` Oliver Schinagl
2013-10-19  9:07                 ` Oliver Schinagl
2013-10-19 18:25                   ` Tom Rini
2013-10-21 19:44                 ` Wolfgang Denk
2014-03-24 10:14                   ` Olliver Schinagl
2013-10-15 18:01 ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131017082748.06618979@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox