public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 04/10] arm: vf610: add anadig pll5 definitions
Date: Thu, 17 Oct 2013 14:38:41 +0200	[thread overview]
Message-ID: <20131017143841.08083d6e@lilith> (raw)
In-Reply-To: <fdf15bc579815452d6f59978938a0fbc90885764.1380539729.git.marcel@ziswiler.com>

Hi Marcel,

On Mon, 30 Sep 2013 13:26:09 +0200, Marcel Ziswiler
<marcel@ziswiler.com> wrote:

> Add ANADIG PLL5 control definitions required for Ethernet RMII clock
> configuration.
> 
> Signed-off-by: Marcel Ziswiler <marcel@ziswiler.com>
> ---
>  arch/arm/include/asm/arch-vf610/crm_regs.h |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/include/asm/arch-vf610/crm_regs.h b/arch/arm/include/asm/arch-vf610/crm_regs.h
> index 04cc5bc..e17c7d1 100644
> --- a/arch/arm/include/asm/arch-vf610/crm_regs.h
> +++ b/arch/arm/include/asm/arch-vf610/crm_regs.h
> @@ -187,6 +187,10 @@ struct anadig_reg {
>  #define CCM_CCGR9_FEC0_CTRL_MASK		0x3
>  #define CCM_CCGR9_FEC1_CTRL_MASK		(0x3 << 2)
>  
> +#define ANADIG_PLL5_CTRL_BYPASS                 (1 << 16)
> +#define ANADIG_PLL5_CTRL_ENABLE                 (1 << 13)
> +#define ANADIG_PLL5_CTRL_POWERDOWN              (1 << 12)
> +#define ANADIG_PLL5_CTRL_DIV_SELECT		1
>  #define ANADIG_PLL2_CTRL_ENABLE			(1 << 13)
>  #define ANADIG_PLL2_CTRL_POWERDOWN		(1 << 12)
>  #define ANADIG_PLL2_CTRL_DIV_SELECT		1

This and 3/10 could be merged as they touch the same file and do the
same thing, adding definitions.

Ditto for 06, 07 and 08/10 which all touch the same file.

I'd even say all addition patches (3/10 to 8/10) could be grouped
together in one logical change, like "add all definitions needed for
vf610".

Amicalement,
-- 
Albert.

  reply	other threads:[~2013-10-17 12:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-30 11:26 [U-Boot] [PATCH v2 00/10] arm: vf610/vf610twr: vybrid tower fixes and enhancements Marcel Ziswiler
2013-09-30 11:26 ` [U-Boot] [PATCH v2 01/10] arm: vf610: fix anadig register struct Marcel Ziswiler
2013-10-17 11:20   ` Albert ARIBAUD
2013-10-17 11:21     ` Albert ARIBAUD
2013-09-30 11:26 ` [U-Boot] [PATCH v2 02/10] arm: vf610: clean-up " Marcel Ziswiler
2013-09-30 11:26 ` [U-Boot] [PATCH v2 03/10] arm: vf610: add uart0 clock definition Marcel Ziswiler
2013-09-30 11:26 ` [U-Boot] [PATCH v2 04/10] arm: vf610: add anadig pll5 definitions Marcel Ziswiler
2013-10-17 12:38   ` Albert ARIBAUD [this message]
2013-09-30 11:26 ` [U-Boot] [PATCH v2 05/10] arm: vf610: add enet1 base address definition Marcel Ziswiler
2013-09-30 11:26 ` [U-Boot] [PATCH v2 06/10] arm: vf610: add rmii clkout iomux definition Marcel Ziswiler
2013-09-30 11:26 ` [U-Boot] [PATCH v2 07/10] arm: vf610: add uart0 tx/rx iomux definitions Marcel Ziswiler
2013-09-30 11:26 ` [U-Boot] [PATCH v2 08/10] arm: vf610: add rmii1 " Marcel Ziswiler
2013-09-30 11:26 ` [U-Boot] [PATCH v2 09/10] arm: vf610: fix double iomux configuration for vf610twr board Marcel Ziswiler
2013-09-30 11:26 ` [U-Boot] [PATCH v2 10/10] arm: vf610: remove obsolete uart port configuration Marcel Ziswiler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131017143841.08083d6e@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox