From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 02/16] sandbox: Correct data sizes and printf() strings in fdtdec.c
Date: Sun, 20 Oct 2013 07:06:55 +0200 [thread overview]
Message-ID: <201310200706.55332.marex@denx.de> (raw)
In-Reply-To: <1382135604-31828-3-git-send-email-sjg@chromium.org>
Dear Simon Glass,
> There are a few warnings in this file when building for sandbox. Addresses
> coming from the device tree need to be treated as ulong as elsewhere in
> U-Boot and we must use map_sysmem() to convert to a pointer when needed.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Acked-by: Marek Vasut <marex@denx.de>
> ---
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
> lib/fdtdec.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/lib/fdtdec.c b/lib/fdtdec.c
> index dc35856..692bcc6 100644
> --- a/lib/fdtdec.c
> +++ b/lib/fdtdec.c
> @@ -84,10 +84,10 @@ fdt_addr_t fdtdec_get_addr_size(const void *blob, int
> node, size = (fdt_size_t *)((char *)cell +
> sizeof(fdt_addr_t));
> *sizep = fdt_size_to_cpu(*size);
> - debug("addr=%p, size=%p\n", (void *)addr,
> - (void *)*sizep);
> + debug("addr=%08lx, size=%08x\n",
> + (ulong)addr, *sizep);
> } else {
> - debug("%p\n", (void *)addr);
> + debug("%08lx\n", (ulong)addr);
> }
> return addr;
> }
> @@ -609,7 +609,7 @@ int fdtdec_decode_region(const void *blob, int node,
> if (!cell || (len != sizeof(fdt_addr_t) * 2))
> return -1;
>
> - *ptrp = (void *)fdt_addr_to_cpu(*cell);
> + *ptrp = map_sysmem(fdt_addr_to_cpu(*cell), *size);
> *size = fdt_size_to_cpu(cell[1]);
> debug("%s: size=%zx\n", __func__, *size);
> return 0;
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-10-20 5:06 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 22:33 [U-Boot] [PATCH v4 0/16] Driver model implementation, tests, demo and GPIO Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 01/16] sandbox: Make map_to_sysmem() use a constant pointer Simon Glass
2013-10-20 5:05 ` Marek Vasut
2013-10-18 22:33 ` [U-Boot] [PATCH v4 02/16] sandbox: Correct data sizes and printf() strings in fdtdec.c Simon Glass
2013-10-20 5:06 ` Marek Vasut [this message]
2013-10-18 22:33 ` [U-Boot] [PATCH v4 03/16] sandbox: config: Don't use 64-bit physical memory Simon Glass
2013-10-20 5:08 ` Marek Vasut
2013-10-20 5:13 ` Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 04/16] sandbox: Build a device tree file for sandbox Simon Glass
2013-10-20 5:09 ` Marek Vasut
2013-10-20 5:23 ` Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 05/16] Add cmd_process_error() to report and process errors Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 06/16] sandbox: config: Enable driver model Simon Glass
2013-10-20 5:11 ` Marek Vasut
2013-10-20 19:05 ` Simon Glass
2013-10-20 19:36 ` Marek Vasut
2013-10-20 20:05 ` Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 07/16] dm: Add README for " Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 08/16] dm: Add base driver model support Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 09/16] dm: Set up driver model after relocation Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 10/16] dm: Add basic tests Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 11/16] dm: Add a 'dm' command for testing Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 12/16] dm: Add a demonstration/example driver Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 13/16] dm: Add GPIO support and tests Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 14/16] sandbox: Convert GPIOs to use driver model Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 15/16] dm: Enable gpio command to support " Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 16/16] dm: Move old driver model documentation into an 'old-docs' directory Simon Glass
2013-10-20 5:12 ` Marek Vasut
2013-10-20 19:34 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201310200706.55332.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox