From: Lukasz Majewski <l.majewski@majess.pl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 1/2] usb: dfu: decrease dfu->r_left along with the transfer
Date: Tue, 22 Oct 2013 00:24:50 +0200 [thread overview]
Message-ID: <20131022002450.4456967b@jawa> (raw)
In-Reply-To: <201310190244.18515.marex@denx.de>
Hi Marek,
> Hi,
>
> > The value of dfu->r_left need decrease along with the transfer
> >
> > Signed-off-by: Bo Shen <voice.shen@atmel.com>
>
> Lucasz/Heiko , can you ACK/NAK this and 2/2 ? Thanks!
For me it looks like a more difficult problem.
I've got an impression that patches proposed by Bo would break eMMC.
Unfortunately I'm now a bit short of time to go deeper to it. Before
ELCE I shall have got a bit more time.
>
> > ---
> > drivers/dfu/dfu.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c
> > index 56b21c7..65c6984 100644
> > --- a/drivers/dfu/dfu.c
> > +++ b/drivers/dfu/dfu.c
> > @@ -229,6 +229,7 @@ static int dfu_read_buffer_fill(struct
> > dfu_entity *dfu, void *buf, int size) dfu->crc = crc32(dfu->crc,
> > buf, chunk); dfu->i_buf += chunk;
> > dfu->b_left -= chunk;
> > + dfu->r_left -= chunk;
> > size -= chunk;
> > buf += chunk;
> > readn += chunk;
>
> Best regards,
> Marek Vasut
Regards,
Lukasz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131022/7623890f/attachment.pgp>
next prev parent reply other threads:[~2013-10-21 22:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 9:26 [U-Boot] [RFC PATCH 1/2] usb: dfu: decrease dfu->r_left along with the transfer Bo Shen
2013-10-16 9:26 ` [U-Boot] [RFC PATCH 2/2] usb: dfu: correct dfu buffer inited value Bo Shen
2013-11-04 10:17 ` Lukasz Majewski
2013-11-05 9:48 ` Bo Shen
2013-11-06 8:54 ` Lukasz Majewski
2013-11-06 13:51 ` Marek Vasut
2013-10-19 0:44 ` [U-Boot] [RFC PATCH 1/2] usb: dfu: decrease dfu->r_left along with the transfer Marek Vasut
2013-10-21 22:24 ` Lukasz Majewski [this message]
2013-10-22 2:42 ` Marek Vasut
2013-11-01 1:18 ` Bo Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131022002450.4456967b@jawa \
--to=l.majewski@majess.pl \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox