From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Tue, 22 Oct 2013 00:24:50 +0200 Subject: [U-Boot] [RFC PATCH 1/2] usb: dfu: decrease dfu->r_left along with the transfer In-Reply-To: <201310190244.18515.marex@denx.de> References: <1381915599-27906-1-git-send-email-voice.shen@atmel.com> <201310190244.18515.marex@denx.de> Message-ID: <20131022002450.4456967b@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Marek, > Hi, > > > The value of dfu->r_left need decrease along with the transfer > > > > Signed-off-by: Bo Shen > > Lucasz/Heiko , can you ACK/NAK this and 2/2 ? Thanks! For me it looks like a more difficult problem. I've got an impression that patches proposed by Bo would break eMMC. Unfortunately I'm now a bit short of time to go deeper to it. Before ELCE I shall have got a bit more time. > > > --- > > drivers/dfu/dfu.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c > > index 56b21c7..65c6984 100644 > > --- a/drivers/dfu/dfu.c > > +++ b/drivers/dfu/dfu.c > > @@ -229,6 +229,7 @@ static int dfu_read_buffer_fill(struct > > dfu_entity *dfu, void *buf, int size) dfu->crc = crc32(dfu->crc, > > buf, chunk); dfu->i_buf += chunk; > > dfu->b_left -= chunk; > > + dfu->r_left -= chunk; > > size -= chunk; > > buf += chunk; > > readn += chunk; > > Best regards, > Marek Vasut Regards, Lukasz -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: not available URL: