From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] kirkwood: ib62x0: use device tree and update config
Date: Tue, 22 Oct 2013 00:28:17 +0200 [thread overview]
Message-ID: <201310220028.18068.marex@denx.de> (raw)
In-Reply-To: <20131014094009-9214@mutt-kz>
Dear Luka Perkov,
> Hi Fabio,
>
> On Sun, Oct 13, 2013 at 11:41:44PM -0300, Fabio Estevam wrote:
> > On Sun, Oct 13, 2013 at 11:38 PM, Luka Perkov <luka@openwrt.org> wrote:
> > > /*
> > >
> > > - * Machine type
> > > + * Enable device tree support
> > >
> > > */
> > >
> > > -#define CONFIG_MACH_TYPE MACH_TYPE_NAS6210
> > > +#define CONFIG_OF_LIBFDT
> >
> > I am not familiar with this platform, but couldn't you also keep
> > CONFIG_MACH_TYPE ?
> >
> > This way people have the option to load both dt and non-dt kernels.
>
> Upstream uses only DT. When uboot support was pushed we had non-DT
> kernel patches that were never merged upstream. IMO we should just drop
> CONFIG_MACH_TYPE and use CONFIG_OF_LIBFDT.
You are breaking compatibility here, so you should keep the machine ID .
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-10-21 22:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 2:38 [U-Boot] [PATCH] kirkwood: ib62x0: use device tree and update config Luka Perkov
2013-10-14 2:41 ` Fabio Estevam
2013-10-14 9:40 ` Luka Perkov
2013-10-21 22:28 ` Marek Vasut [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-10-31 3:05 Luka Perkov
2013-10-31 3:33 ` Prafulla Wadaskar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201310220028.18068.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox