From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Tue, 22 Oct 2013 00:28:17 +0200
Subject: [U-Boot] [PATCH] kirkwood: ib62x0: use device tree and update
	config
In-Reply-To: <20131014094009-9214@mutt-kz>
References: <1381718283-8387-1-git-send-email-luka@openwrt.org>
	<CAOMZO5D6TyX_H4_dHxq4d3w6_N9-JafAM5PLfRkn5OB-yf0P=g@mail.gmail.com>
	<20131014094009-9214@mutt-kz>
Message-ID: <201310220028.18068.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Luka Perkov,

> Hi Fabio,
> 
> On Sun, Oct 13, 2013 at 11:41:44PM -0300, Fabio Estevam wrote:
> > On Sun, Oct 13, 2013 at 11:38 PM, Luka Perkov <luka@openwrt.org> wrote:
> > >  /*
> > > 
> > > - * Machine type
> > > + * Enable device tree support
> > > 
> > >   */
> > > 
> > > -#define CONFIG_MACH_TYPE       MACH_TYPE_NAS6210
> > > +#define CONFIG_OF_LIBFDT
> > 
> > I am not familiar with this platform, but couldn't you also keep
> > CONFIG_MACH_TYPE ?
> > 
> > This way people have the option to load both dt and non-dt kernels.
> 
> Upstream uses only DT. When uboot support was pushed we had non-DT
> kernel patches that were never merged upstream. IMO we should just drop
> CONFIG_MACH_TYPE and use CONFIG_OF_LIBFDT.

You are breaking compatibility here, so you should keep the machine ID .

Best regards,
Marek Vasut