public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb:ohci-hcd: submit_common_msg: report actual_length properly
Date: Wed, 23 Oct 2013 03:02:40 +0200	[thread overview]
Message-ID: <201310230302.40605.marex@denx.de> (raw)
In-Reply-To: <5266F50A.3050201@gmail.com>

Dear Mateusz Kulikowski,

> submit_common_msg should report amount of data passed from/to device.
> Instead, it always returned size requested by Host.
> 
> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
> ---
>   drivers/usb/host/ohci-hcd.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c
> index c33c487..8a9e5f4 100644
> --- a/drivers/usb/host/ohci-hcd.c
> +++ b/drivers/usb/host/ohci-hcd.c
> @@ -1548,7 +1548,7 @@ int submit_common_msg(struct usb_device *dev,
> unsigned long pipe, void *buffer, }
> 
>          dev->status = stat;
> -       dev->act_len = transfer_len;
> +       dev->act_len = urb->actual_length;
> 
>   #ifdef DEBUG
>          pkt_print(urb, dev, pipe, buffer, transfer_len,

The patch is malformed somehow and cannot be applied. For one, I see spaces 
instead of tabs. Fix and repost please.

NOTE: I will be N/A until the end of this week.

Best regards,
Marek Vasut

  reply	other threads:[~2013-10-23  1:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-22 21:58 [U-Boot] [PATCH] usb:ohci-hcd: submit_common_msg: report actual_length properly Mateusz Kulikowski
2013-10-23  1:02 ` Marek Vasut [this message]
2013-10-23 18:26   ` [U-Boot] [PATCH v2] usb: ohci-hcd: " Mateusz Kulikowski
2013-10-28  9:03     ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201310230302.40605.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox