* [U-Boot] [PATCH] usb:ohci-hcd: submit_common_msg: report actual_length properly
@ 2013-10-22 21:58 Mateusz Kulikowski
2013-10-23 1:02 ` Marek Vasut
0 siblings, 1 reply; 4+ messages in thread
From: Mateusz Kulikowski @ 2013-10-22 21:58 UTC (permalink / raw)
To: u-boot
submit_common_msg should report amount of data passed from/to device.
Instead, it always returned size requested by Host.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
---
drivers/usb/host/ohci-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c
index c33c487..8a9e5f4 100644
--- a/drivers/usb/host/ohci-hcd.c
+++ b/drivers/usb/host/ohci-hcd.c
@@ -1548,7 +1548,7 @@ int submit_common_msg(struct usb_device *dev, unsigned long pipe, void *buffer,
}
dev->status = stat;
- dev->act_len = transfer_len;
+ dev->act_len = urb->actual_length;
#ifdef DEBUG
pkt_print(urb, dev, pipe, buffer, transfer_len,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] usb:ohci-hcd: submit_common_msg: report actual_length properly
2013-10-22 21:58 [U-Boot] [PATCH] usb:ohci-hcd: submit_common_msg: report actual_length properly Mateusz Kulikowski
@ 2013-10-23 1:02 ` Marek Vasut
2013-10-23 18:26 ` [U-Boot] [PATCH v2] usb: ohci-hcd: " Mateusz Kulikowski
0 siblings, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2013-10-23 1:02 UTC (permalink / raw)
To: u-boot
Dear Mateusz Kulikowski,
> submit_common_msg should report amount of data passed from/to device.
> Instead, it always returned size requested by Host.
>
> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
> ---
> drivers/usb/host/ohci-hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c
> index c33c487..8a9e5f4 100644
> --- a/drivers/usb/host/ohci-hcd.c
> +++ b/drivers/usb/host/ohci-hcd.c
> @@ -1548,7 +1548,7 @@ int submit_common_msg(struct usb_device *dev,
> unsigned long pipe, void *buffer, }
>
> dev->status = stat;
> - dev->act_len = transfer_len;
> + dev->act_len = urb->actual_length;
>
> #ifdef DEBUG
> pkt_print(urb, dev, pipe, buffer, transfer_len,
The patch is malformed somehow and cannot be applied. For one, I see spaces
instead of tabs. Fix and repost please.
NOTE: I will be N/A until the end of this week.
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH v2] usb: ohci-hcd: submit_common_msg: report actual_length properly
2013-10-23 1:02 ` Marek Vasut
@ 2013-10-23 18:26 ` Mateusz Kulikowski
2013-10-28 9:03 ` Marek Vasut
0 siblings, 1 reply; 4+ messages in thread
From: Mateusz Kulikowski @ 2013-10-23 18:26 UTC (permalink / raw)
To: u-boot
submit_common_msg should report amount of data passed from/to device.
Instead, it always returned size requested by Host.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
---
drivers/usb/host/ohci-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c
index c33c487..8a9e5f4 100644
--- a/drivers/usb/host/ohci-hcd.c
+++ b/drivers/usb/host/ohci-hcd.c
@@ -1548,7 +1548,7 @@ int submit_common_msg(struct usb_device *dev, unsigned long pipe, void *buffer,
}
dev->status = stat;
- dev->act_len = transfer_len;
+ dev->act_len = urb->actual_length;
#ifdef DEBUG
pkt_print(urb, dev, pipe, buffer, transfer_len,
--
1.8.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH v2] usb: ohci-hcd: submit_common_msg: report actual_length properly
2013-10-23 18:26 ` [U-Boot] [PATCH v2] usb: ohci-hcd: " Mateusz Kulikowski
@ 2013-10-28 9:03 ` Marek Vasut
0 siblings, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2013-10-28 9:03 UTC (permalink / raw)
To: u-boot
Dear Mateusz Kulikowski,
> submit_common_msg should report amount of data passed from/to device.
> Instead, it always returned size requested by Host.
>
> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
> ---
> drivers/usb/host/ohci-hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c
> index c33c487..8a9e5f4 100644
> --- a/drivers/usb/host/ohci-hcd.c
> +++ b/drivers/usb/host/ohci-hcd.c
> @@ -1548,7 +1548,7 @@ int submit_common_msg(struct usb_device *dev,
> unsigned long pipe, void *buffer, }
>
> dev->status = stat;
> - dev->act_len = transfer_len;
> + dev->act_len = urb->actual_length;
>
> #ifdef DEBUG
> pkt_print(urb, dev, pipe, buffer, transfer_len,
Applied, thanks!
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-28 9:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-22 21:58 [U-Boot] [PATCH] usb:ohci-hcd: submit_common_msg: report actual_length properly Mateusz Kulikowski
2013-10-23 1:02 ` Marek Vasut
2013-10-23 18:26 ` [U-Boot] [PATCH v2] usb: ohci-hcd: " Mateusz Kulikowski
2013-10-28 9:03 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox