public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Illegal use of FP ops in clock_ti814x.c
Date: Sun, 27 Oct 2013 22:11:57 +0100	[thread overview]
Message-ID: <20131027211157.1AF2E380495@gemini.denx.de> (raw)

Dear Matt,

I hope you are the right person to address this to - if not, please
help to redirect to the current responsible developer.

Function pll_sigma_delta_val() in arch/arm/cpu/armv7/am33xx/clock_ti814x.c
incorrectly uses "float" data, which results in FP operations which
are not permitted in U-Boot.

The actual computation appears simple enough so a rewrite of the code
without using any floating point operations should be fairly easy, but
I don't understand the actual logic of this code, so I'd rather leave
this to someone who does.

Could you please help and clean up these three lines of code?

Thanks in advance.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Here is an Appalachian version of management's answer  to  those  who
are  concerned  with  the fate of the project: "Don't worry about the
mule. Just load the wagon."         - Mike Dennison's hillbilly uncle

             reply	other threads:[~2013-10-27 21:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-27 21:11 Wolfgang Denk [this message]
2013-10-28 21:55 ` [U-Boot] Illegal use of FP ops in clock_ti814x.c Tom Rini
2013-10-28 23:19 ` Måns Rullgård
2013-10-28 23:56   ` Wolfgang Denk
2013-10-29  0:54     ` Måns Rullgård
2013-10-29 10:48       ` Wolfgang Denk
2013-10-29 12:23         ` Tom Rini
2014-01-28 17:48           ` Matt Porter
2013-10-29 12:44         ` Måns Rullgård
2014-02-21 19:14   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131027211157.1AF2E380495@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox