public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] video, formike: change tag/val write
@ 2013-10-22  9:06 Heiko Schocher
  2013-10-30  9:50 ` Anatolij Gustschin
  0 siblings, 1 reply; 2+ messages in thread
From: Heiko Schocher @ 2013-10-22  9:06 UTC (permalink / raw)
  To: u-boot

write first the "tag" 8 bit value and then the "val" 8-bit
to the display.

Tested on the rut board.

Signed-off-by: Heiko Schocher <hs@denx.de>
Cc: Anatolij Gustschin <agust@denx.de>
---
 drivers/video/formike.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/video/formike.c b/drivers/video/formike.c
index b9b6822..1383158 100644
--- a/drivers/video/formike.c
+++ b/drivers/video/formike.c
@@ -27,10 +27,11 @@ static int spi_write_tag_val(struct spi_slave *spi, unsigned char tag,
 	int ret;
 
 	buf[0] = tag;
-	buf[1] = val;
-	flags |= SPI_XFER_END;
+	ret = spi_xfer(spi, 8, buf, NULL, flags);
+	buf[0] = val;
+	flags = SPI_XFER_END;
+	ret = spi_xfer(spi, 8, buf, NULL, flags);
 
-	ret = spi_xfer(spi, 16, buf, NULL, flags);
 #ifdef KWH043ST20_F01_SPI_DEBUG
 	printf("spi_write_tag_val: tag=%02X, val=%02X ret: %d\n",
 	       tag, val, ret);
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH] video, formike: change tag/val write
  2013-10-22  9:06 [U-Boot] [PATCH] video, formike: change tag/val write Heiko Schocher
@ 2013-10-30  9:50 ` Anatolij Gustschin
  0 siblings, 0 replies; 2+ messages in thread
From: Anatolij Gustschin @ 2013-10-30  9:50 UTC (permalink / raw)
  To: u-boot

On Tue, 22 Oct 2013 11:06:24 +0200
Heiko Schocher <hs@denx.de> wrote:

> write first the "tag" 8 bit value and then the "val" 8-bit
> to the display.
> 
> Tested on the rut board.
> 
> Signed-off-by: Heiko Schocher <hs@denx.de>
> Cc: Anatolij Gustschin <agust@denx.de>
> ---
>  drivers/video/formike.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

applied to u-boot-video/master, thanks!

Anatolij

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-10-30  9:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-22  9:06 [U-Boot] [PATCH] video, formike: change tag/val write Heiko Schocher
2013-10-30  9:50 ` Anatolij Gustschin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox