From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i2c: mxs_i2c: Squash endless loop
Date: Mon, 4 Nov 2013 12:50:21 +0100 [thread overview]
Message-ID: <201311041250.21642.marex@denx.de> (raw)
In-Reply-To: <52776267.7020905@denx.de>
Hi Stefano,
> Hi Marek,
>
> On 02/11/2013 18:23, Marek Vasut wrote:
> > + if (!timeout) {
> > + debug("MXS I2C: Failed receiving data!\n");
> > + return -EINVAL;
> > + }
> > +
>
> This is a real error and not a debug information. IMHO it should be
> better to print the error unconditionally with puts/printf, reporting
> that the timer elapsed.
Returning -EINVAL will make the i2c stack trigger an output, so having it
duplicated here is pointless I believe.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-11-04 11:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-02 17:23 [U-Boot] [PATCH] i2c: mxs_i2c: Squash endless loop Marek Vasut
2013-11-04 9:01 ` Stefano Babic
2013-11-04 11:50 ` Marek Vasut [this message]
2013-11-04 12:03 ` Stefano Babic
2013-11-04 12:18 ` Heiko Schocher
2013-11-04 13:13 ` Marek Vasut
2013-11-04 13:21 ` Heiko Schocher
2013-11-04 13:29 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201311041250.21642.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox