From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Mon, 4 Nov 2013 12:50:21 +0100
Subject: [U-Boot] [PATCH] i2c: mxs_i2c: Squash endless loop
In-Reply-To: <52776267.7020905@denx.de>
References: <1383413009-4912-1-git-send-email-marex@denx.de>
	<52776267.7020905@denx.de>
Message-ID: <201311041250.21642.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Stefano,

> Hi Marek,
> 
> On 02/11/2013 18:23, Marek Vasut wrote:
> > +			if (!timeout) {
> > +				debug("MXS I2C: Failed receiving data!\n");
> > +				return -EINVAL;
> > +			}
> > +
> 
> This is a real error and not a debug information. IMHO it should be
> better to print the error unconditionally with puts/printf, reporting
> that the timer elapsed.

Returning -EINVAL will make the i2c stack trigger an output, so having it 
duplicated here is pointless I believe.

Best regards,
Marek Vasut