From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
Date: Tue, 5 Nov 2013 09:12:16 +0100
Subject: [U-Boot] [PATCH 3/4] arm: rmobile: Add support R8A7791
In-Reply-To: <CABMQnVJRCQG-BDCNRiM5TNvOsRDawHAwc-tirOyPEM2Gm8D8Cg@mail.gmail.com>
References: <1380004715-15014-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>
	<1380004715-15014-3-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>
	<20131017130406.5878248f@lilith> <20131030100456.761ed8a4@lilith>
	<CABMQnVKsepr7voN+qVRjSSYdTtkq--8j-2YjR1Ny6UwBWsbyNw@mail.gmail.com>
	<CABMQnVJRCQG-BDCNRiM5TNvOsRDawHAwc-tirOyPEM2Gm8D8Cg@mail.gmail.com>
Message-ID: <20131105091216.265885cd@lilith>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Nobuhiro,

On Thu, 31 Oct 2013 17:18:54 +0900, Nobuhiro Iwamatsu
<nobuhiro.iwamatsu.yj@renesas.com> wrote:

> Hi, again.
> 
> 2013/10/31 Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>:
> > Hi, Albert.
> >
> > Sorry, I dont notice your mail.
> >
> > 2013/10/30 Albert ARIBAUD <albert.u.boot@aribaud.net>:
> >> On Thu, 17 Oct 2013 13:04:06 +0200, Albert ARIBAUD
> >> <albert.u.boot@aribaud.net> wrote:
> >>
> >>> Hi Nobuhiro,
> >>>
> >>> On Tue, 24 Sep 2013 15:38:34 +0900, Nobuhiro Iwamatsu
> >>> <nobuhiro.iwamatsu.yj@renesas.com> wrote:
> >>>
> >>> > Renesas R8A7791 is CPU with Cortex-A7 and A15.
> >>> > This supports the basic register definition and GPIO and
> >>> > framework of PFC.
> >>> >
> >>> > Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> >>> > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> >>> > CC: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> >>> > CC: Albert Aribaud <albert.u.boot@aribaud.net>
> >>> > ---
> >>> >  arch/arm/cpu/armv7/rmobile/Makefile              |    2 +
> >>> >  arch/arm/cpu/armv7/rmobile/cpu_info-r8a7791.c    |   29 +
> >>> >  arch/arm/cpu/armv7/rmobile/cpu_info.c            |    5 +
> >>> >  arch/arm/cpu/armv7/rmobile/pfc-r8a7791.c         | 3415 ++++++++++++++++++++++
> >>>
> >>> Is there no way to make this big file common between R8A7790 and
> >>> R8A7791?
> >
> > Thanks for your comment.
> >
> > Sorry, do you mean that  "Can you common the  PFC of r8a7790 and
> > r8a7791?", because this file is large and
> > these can be used in common.
> > Right?
> >
> > If this is right, I will merge these file and re-send.
> >
> 
> I tried common  between R8A7790 and R8A7791.
> But these files have  register infomation of Pin Function Controller.
> Register configuration is different from these, there is almost no common parts.
> However, I found a common part of some. It is possible to separate them.

If this can reduce the overall source code size, please do so.

> Best regards,
>    Nobuhiro

Amicalement,
-- 
Albert.