From: Matt Porter <matt.porter@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] am33xx: Stop modifying certain EMIF4D registers
Date: Thu, 7 Nov 2013 16:24:38 -0500 [thread overview]
Message-ID: <20131107212438.GV28156@beef> (raw)
In-Reply-To: <527C0338.60706@ti.com>
On Thu, Nov 07, 2013 at 04:16:40PM -0500, Tom Rini wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 11/07/2013 04:12 PM, Vaibhav Bedia wrote:
> > Hi Tom,
> >
> > On Thu, Nov 7, 2013 at 11:42 AM, Tom Rini <trini@ti.com> wrote:
> >> Based on the definitive guide to EMIF configuration[1] certain registers
> >> that we have been modifying (and are documented registers) should be
> >> left in their reset values rather than modified. This has been tested
> >> on AM335x GP EVM and Beaglebone White.
> >>
> >
> > [...]
> [snip]
> >> @@ -198,11 +188,6 @@ void sdram_init(void)
> >> config_dmm(&evm_lisa_map_regs);
> >>
> >> #ifdef CONFIG_TI816X_EVM_DDR2
> >> - ddr2_data.datadldiff0 = (get_cpu_rev() == 0x1 ? 0x0 : 0xF);
> >> - ddr2_ctrl.cmd0dldiff = (get_cpu_rev() == 0x1 ? 0x0 : 0xF);
> >> - ddr2_ctrl.cmd1dldiff = (get_cpu_rev() == 0x1 ? 0x0 : 0xF);
> >> - ddr2_ctrl.cmd2dldiff = (get_cpu_rev() == 0x1 ? 0x0 : 0xF);
> >> -
> >> if (CONFIG_TI816X_USE_EMIF0) {
> >> ddr2_emif0_regs.emif_ddr_phy_ctlr_1 =
> >> (get_cpu_rev() == 0x1 ? 0x0000010B : 0x0000030B);
> >> @@ -217,8 +202,6 @@ void sdram_init(void)
> >> #endif
> >>
> >> #ifdef CONFIG_TI816X_EVM_DDR3
> >> - ddr3_data.datadldiff0 = (get_cpu_rev() == 0x1 ? 0x0 : 0xF);
> >> -
> >
> > From a quick glance it looks like at least earlier variants of TI81xx
> > used these registers to work around some bugs? This might end up
> > breaking those. Note that TI81xx DDR frequencies are much higher
> > compared to AM335x so issues related to this might not show up
> > right now.
>
> It's an open question on if TI81xx needs these set or was simply also
> setting them for historical reasons (and in turn was inherited by am335x).
I will doublecheck on my early TI8148...out of time today but tomorrow.
-Matt
next prev parent reply other threads:[~2013-11-07 21:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 16:42 [U-Boot] [PATCH] am33xx: Stop modifying certain EMIF4D registers Tom Rini
2013-11-07 21:12 ` Vaibhav Bedia
2013-11-07 21:16 ` Tom Rini
2013-11-07 21:24 ` Matt Porter [this message]
2013-11-18 20:44 ` Vaibhav Bedia
2013-11-15 18:04 ` Matt Porter
2013-12-04 22:03 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107212438.GV28156@beef \
--to=matt.porter@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox