public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@majess.pl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] usb: dfu: make nand upload working
Date: Fri, 8 Nov 2013 16:41:49 +0100	[thread overview]
Message-ID: <20131108164149.7ead094a@jawa> (raw)
In-Reply-To: <1383805781-23146-1-git-send-email-voice.shen@atmel.com>

Hi Bo,

> Nowhere pass a value to len, which always 0, make no transfer which
> cause uploading failed.
> 
> This patch make nand upload working. However it needs enough malloc
> buffer to store read data, that means the buffer at least equal to
> the upload partition size, or else it doesn't work.
> 
> Signed-off-by: Bo Shen <voice.shen@atmel.com>

I would kindly ask some users of NAND part of the DFU (Tom, Heiko) to
test if this change doesn't break anything.


> ---
> Changes in v2:
>   - Move code to nand part, or else it will break mmc
> 
>  drivers/dfu/dfu_nand.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/dfu/dfu_nand.c b/drivers/dfu/dfu_nand.c
> index 1c2e03b..cf082e2 100644
> --- a/drivers/dfu/dfu_nand.c
> +++ b/drivers/dfu/dfu_nand.c
> @@ -121,6 +121,7 @@ static int dfu_read_medium_nand(struct dfu_entity
> *dfu, u64 offset, void *buf, 
>  	switch (dfu->layout) {
>  	case DFU_RAW_ADDR:
> +		*len = dfu->data.nand.size;
>  		ret = nand_block_read(dfu, offset, buf, len);
>  		break;
>  	default:

Best regards,
Lukasz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131108/2c056ace/attachment.pgp>

  parent reply	other threads:[~2013-11-08 15:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-07  6:29 [U-Boot] [PATCH v2] usb: dfu: make nand upload working Bo Shen
2013-11-08 12:14 ` Heiko Schocher
2013-11-08 15:41 ` Lukasz Majewski [this message]
2013-11-11  6:46   ` Heiko Schocher
2013-11-11  8:17     ` Bo Shen
2013-11-11 13:29       ` Marek Vasut
2013-11-08 19:45 ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131108164149.7ead094a@jawa \
    --to=l.majewski@majess.pl \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox