[U-Boot] Question about patman

[U-Boot] Question about patman

[Masahiro Yamada]

Hello Simon.

I'm trying patman, but it looks like
it doesn't work on my Ubuntu box.

How can I resove the following issue?



The subject of HEAD is 
    ARM: align MVBAR on 32 byte boundary


and the result of my dry run is:

$ python --version
Python 2.7.4
$ tools/patman/patman -n -c1 
Cleaned 1 patches
Traceback (most recent call last):
  File "tools/patman/patman", line 153, in <module>
    not options.ignore_bad_tags)
  File "/home/yamada/workspace/arm-linux-pf/u-boot/tools/patman/series.py", line 225, in MakeCcFile
    raise_on_error=raise_on_error)
  File "/home/yamada/workspace/arm-linux-pf/u-boot/tools/patman/gitutil.py", line 308, in BuildEmailList
    raw += LookupEmail(item, alias, raise_on_error=raise_on_error)
  File "/home/yamada/workspace/arm-linux-pf/u-boot/tools/patman/gitutil.py", line 472, in LookupEmail
    raise ValueError, msg
ValueError: Alias 'arm' not found






Best Regards
Masahiro Yamada

[U-Boot] Question about patman

[Simon Glass]

Hi Masahiro,

On Sun, Oct 27, 2013 at 11:37 PM, Masahiro Yamada
<yamada.m@jp.panasonic.com> wrote:
> Hello Simon.
>
> I'm trying patman, but it looks like
> it doesn't work on my Ubuntu box.
>
> How can I resove the following issue?
>
>
>
> The subject of HEAD is
>     ARM: align MVBAR on 32 byte boundary
>
>
> and the result of my dry run is:
>
> $ python --version
> Python 2.7.4
> $ tools/patman/patman -n -c1
> Cleaned 1 patches
> Traceback (most recent call last):
>   File "tools/patman/patman", line 153, in <module>
>     not options.ignore_bad_tags)
>   File "/home/yamada/workspace/arm-linux-pf/u-boot/tools/patman/series.py", line 225, in MakeCcFile
>     raise_on_error=raise_on_error)
>   File "/home/yamada/workspace/arm-linux-pf/u-boot/tools/patman/gitutil.py", line 308, in BuildEmailList
>     raw += LookupEmail(item, alias, raise_on_error=raise_on_error)
>   File "/home/yamada/workspace/arm-linux-pf/u-boot/tools/patman/gitutil.py", line 472, in LookupEmail
>     raise ValueError, msg
> ValueError: Alias 'arm' not found
>

You should put an alias for arm in your ~/.patman file, like this:

albert: Albert Aribaud <albert.u.boot@aribaud.net>
arm: albert

There is also a -t option to skip bad aliases.

Regards,
Simon

[U-Boot] Question about patman

[Masahiro Yamada]

Hello Simon.

> You should put an alias for arm in your ~/.patman file, like this:
> 
> albert: Albert Aribaud <albert.u.boot@aribaud.net>
> arm: albert
> 
> There is also a -t option to skip bad aliases.

Thanks! It worked.
I love this tool.  :-)

I have one more question.
Does patman have a tag to handle the message area below
the delimiter, '---' ?

I often use the area for writing additional explanations, which
might be too verbose to be included into git log,
but might be helpful for the code review.

I generally write in the area below '---' with a text editor
before posting the patch file.

If patman could do this for me,
it would be appreciated.

Best Regards
Masahiro Yamada

[U-Boot] Question about patman

[Albert ARIBAUD]

Hi Masahiro,

On Tue, 05 Nov 2013 12:47:05 +0900, Masahiro Yamada
<yamada.m@jp.panasonic.com> wrote:

> Hello Simon.
> 
> > You should put an alias for arm in your ~/.patman file, like this:
> > 
> > albert: Albert Aribaud <albert.u.boot@aribaud.net>
> > arm: albert
> > 
> > There is also a -t option to skip bad aliases.
> 
> Thanks! It worked.
> I love this tool.  :-)
> 
> I have one more question.
> Does patman have a tag to handle the message area below
> the delimiter, '---' ?
> 
> I often use the area for writing additional explanations, which
> might be too verbose to be included into git log,
> but might be helpful for the code review.
> 
> I generally write in the area below '---' with a text editor
> before posting the patch file.
> 
> If patman could do this for me,
> it would be appreciated.

I have posted a patch to allow adding notes below the '---' line, if
this is what you mean. So far, there was no comment on it. See:

http://patchwork.ozlabs.org/patch/283057/

> Best Regards
> Masahiro Yamada

Amicalement,
-- 
Albert.

[U-Boot] Question about patman

[Masahiro Yamada]

Hello Albert.

> I have posted a patch to allow adding notes below the '---' line, if
> this is what you mean. So far, there was no comment on it. See:
> 
> http://patchwork.ozlabs.org/patch/283057/

Yeah!
This is the function exactly I have wanted.

Thank you.

Beat Regards
Masahiro Yamada

[U-Boot] Question about patman

[Otavio Salvador]

On Sun, Nov 10, 2013 at 11:39 PM, Masahiro Yamada
<yamada.m@jp.panasonic.com> wrote:
> Hello Albert.
>
>> I have posted a patch to allow adding notes below the '---' line, if
>> this is what you mean. So far, there was no comment on it. See:
>>
>> http://patchwork.ozlabs.org/patch/283057/
>
> Yeah!
> This is the function exactly I have wanted.

Neat :-)

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750