public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 3/6] arm: pxa: move SP check from start.S to cpuinfo.c
Date: Sat, 9 Nov 2013 03:27:23 +0100	[thread overview]
Message-ID: <201311090327.23777.marex@denx.de> (raw)
In-Reply-To: <1383945479-6499-4-git-send-email-albert.u.boot@aribaud.net>

Dear Albert ARIBAUD,

> PXA start.S has a PXA (variant) specific check in
> start.S. Move it to cpuinfo.c.
> 
> Signed-off-by: Albert ARIBAUD <albert.u.boot@aribaud.net>

Either way WFM

Acked-by: Marek Vasut <marex@denx.de>

> ---
>  arch/arm/cpu/pxa/cpuinfo.c | 6 ++++++
>  arch/arm/cpu/pxa/start.S   | 6 ------
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/cpu/pxa/cpuinfo.c b/arch/arm/cpu/pxa/cpuinfo.c
> index 9d16079..17d8be5 100644
> --- a/arch/arm/cpu/pxa/cpuinfo.c
> +++ b/arch/arm/cpu/pxa/cpuinfo.c
> @@ -11,6 +11,12 @@
>  #include <errno.h>
>  #include <linux/compiler.h>
> 
> +#ifdef CONFIG_CPU_PXA25X
> +#if ((CONFIG_SYS_INIT_SP_ADDR) != 0xfffff800)
> +#error "Init SP address must be set to 0xfffff800 for PXA250"
> +#endif
> +#endif
> +
>  #define	CPU_MASK_PXA_PRODID	0x000003f0
>  #define	CPU_MASK_PXA_REVID	0x0000000f
> 
> diff --git a/arch/arm/cpu/pxa/start.S b/arch/arm/cpu/pxa/start.S
> index ae0d13c..eb3243a 100644
> --- a/arch/arm/cpu/pxa/start.S
> +++ b/arch/arm/cpu/pxa/start.S
> @@ -23,12 +23,6 @@
>  #include <config.h>
>  #include <version.h>
> 
> -#ifdef CONFIG_CPU_PXA25X
> -#if ((CONFIG_SYS_INIT_SP_ADDR) != 0xfffff800)
> -#error "Init SP address must be set to 0xfffff800 for PXA250"
> -#endif
> -#endif
> -
>  .globl _start
>  _start: b	reset
>  #ifdef CONFIG_SPL_BUILD

Best regards,
Marek Vasut

  parent reply	other threads:[~2013-11-09  2:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-08 21:17 [U-Boot] [PATCH v1 0/6] ARM: refactor start.S files Albert ARIBAUD
2013-11-08 21:17 ` [U-Boot] [PATCH v1 1/6] arm1136: move cache code from start.S to cache.c Albert ARIBAUD
2013-11-08 21:17   ` [U-Boot] [PATCH v1 2/6] arm: move reset_cpu from start.S into cpu.c Albert ARIBAUD
2013-11-08 21:17     ` [U-Boot] [PATCH v1 3/6] arm: pxa: move SP check from start.S to cpuinfo.c Albert ARIBAUD
2013-11-08 21:17       ` [U-Boot] [PATCH v1 4/6] arm: ixp: cosmetic: move code around in start.S Albert ARIBAUD
2013-11-08 21:17         ` [U-Boot] [PATCH v1 5/6] arm: remove unused _end_vect and _vectors_end symbols Albert ARIBAUD
2013-11-08 21:17           ` [U-Boot] [PATCH v1 6/6] arm: move exception handling out of start.S files Albert ARIBAUD
2013-11-09  2:27       ` Marek Vasut [this message]
2013-11-08 22:34     ` [U-Boot] [PATCH v1 2/6] arm: move reset_cpu from start.S into cpu.c Benoît Thébaudeau
2013-11-08 21:42   ` [U-Boot] [PATCH v1 1/6] arm1136: move cache code from start.S to cache.c Benoît Thébaudeau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201311090327.23777.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox