public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 1/2] ARM: bcm2835: add missing mbox overscan response field
@ 2013-10-22 20:27 Andre Heider
  2013-10-23 16:54 ` Stephen Warren
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Andre Heider @ 2013-10-22 20:27 UTC (permalink / raw)
  To: u-boot

Add the missing "right" field to struct bcm2835_mbox_tag_overscan.

Signed-off-by: Andre Heider <a.heider@gmail.com>
---
 arch/arm/include/asm/arch-bcm2835/mbox.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/include/asm/arch-bcm2835/mbox.h b/arch/arm/include/asm/arch-bcm2835/mbox.h
index 24abe57..6b806ec 100644
--- a/arch/arm/include/asm/arch-bcm2835/mbox.h
+++ b/arch/arm/include/asm/arch-bcm2835/mbox.h
@@ -350,6 +350,7 @@ struct bcm2835_mbox_tag_overscan {
 			u32 top;
 			u32 bottom;
 			u32 left;
+			u32 right;
 		} resp;
 	} body;
 };
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH 1/2] ARM: bcm2835: add missing mbox overscan response field
  2013-10-22 20:27 [U-Boot] [PATCH 1/2] ARM: bcm2835: add missing mbox overscan response field Andre Heider
@ 2013-10-23 16:54 ` Stephen Warren
  2013-10-23 19:46   ` Andre Heider
  2013-11-08 12:13 ` Albert ARIBAUD
  2013-11-09 10:11 ` Anatolij Gustschin
  2 siblings, 1 reply; 8+ messages in thread
From: Stephen Warren @ 2013-10-23 16:54 UTC (permalink / raw)
  To: u-boot

On 10/22/2013 09:27 PM, Andre Heider wrote:
> Add the missing "right" field to struct bcm2835_mbox_tag_overscan.

This one patch,
Acked-by: Stephen Warren <swarren@wwwdotorg.org>

You need to send/cc this patch to Albert Aribauld, since he applies ARM
patches. Or, perhaps just make sure the patch gets assigned to him in
patchwork?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH 1/2] ARM: bcm2835: add missing mbox overscan response field
  2013-10-23 16:54 ` Stephen Warren
@ 2013-10-23 19:46   ` Andre Heider
  2013-11-07 13:29     ` Albert ARIBAUD
  0 siblings, 1 reply; 8+ messages in thread
From: Andre Heider @ 2013-10-23 19:46 UTC (permalink / raw)
  To: u-boot

On Wed, Oct 23, 2013 at 05:54:13PM +0100, Stephen Warren wrote:
> On 10/22/2013 09:27 PM, Andre Heider wrote:
> > Add the missing "right" field to struct bcm2835_mbox_tag_overscan.
> 
> This one patch,
> Acked-by: Stephen Warren <swarren@wwwdotorg.org>
> 
> You need to send/cc this patch to Albert Aribauld, since he applies ARM
> patches. Or, perhaps just make sure the patch gets assigned to him in
> patchwork?

Okay, I did the patchwork dance :)

Thanks,
Andre

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH 1/2] ARM: bcm2835: add missing mbox overscan response field
  2013-10-23 19:46   ` Andre Heider
@ 2013-11-07 13:29     ` Albert ARIBAUD
  2013-11-07 21:30       ` Stephen Warren
  0 siblings, 1 reply; 8+ messages in thread
From: Albert ARIBAUD @ 2013-11-07 13:29 UTC (permalink / raw)
  To: u-boot

Hi Andre,

On Wed, 23 Oct 2013 21:46:31 +0200, Andre Heider <a.heider@gmail.com>
wrote:

> On Wed, Oct 23, 2013 at 05:54:13PM +0100, Stephen Warren wrote:
> > On 10/22/2013 09:27 PM, Andre Heider wrote:
> > > Add the missing "right" field to struct bcm2835_mbox_tag_overscan.
> > 
> > This one patch,
> > Acked-by: Stephen Warren <swarren@wwwdotorg.org>
> > 
> > You need to send/cc this patch to Albert Aribauld, since he applies ARM
> > patches. Or, perhaps just make sure the patch gets assigned to him in
> > patchwork?
> 
> Okay, I did the patchwork dance :)
> 
> Thanks,
> Andre

In fact, the series could be applied as a whole by the same custodian
-- and actually, I'd prefer it to be applied as a whole, since patch 1/2
alone looks like dead/useless code, whereas it makes sense if applied
along with 2/2.

Amicalement,
-- 
Albert.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH 1/2] ARM: bcm2835: add missing mbox overscan response field
  2013-11-07 13:29     ` Albert ARIBAUD
@ 2013-11-07 21:30       ` Stephen Warren
  2013-11-08 12:16         ` Albert ARIBAUD
  0 siblings, 1 reply; 8+ messages in thread
From: Stephen Warren @ 2013-11-07 21:30 UTC (permalink / raw)
  To: u-boot

On 11/07/2013 06:29 AM, Albert ARIBAUD wrote:
> Hi Andre,
> 
> On Wed, 23 Oct 2013 21:46:31 +0200, Andre Heider <a.heider@gmail.com>
> wrote:
> 
>> On Wed, Oct 23, 2013 at 05:54:13PM +0100, Stephen Warren wrote:
>>> On 10/22/2013 09:27 PM, Andre Heider wrote:
>>>> Add the missing "right" field to struct bcm2835_mbox_tag_overscan.
>>>
>>> This one patch,
>>> Acked-by: Stephen Warren <swarren@wwwdotorg.org>
>>>
>>> You need to send/cc this patch to Albert Aribauld, since he applies ARM
>>> patches. Or, perhaps just make sure the patch gets assigned to him in
>>> patchwork?
>>
>> Okay, I did the patchwork dance :)
>>
>> Thanks,
>> Andre
> 
> In fact, the series could be applied as a whole by the same custodian
> -- and actually, I'd prefer it to be applied as a whole, since patch 1/2
> alone looks like dead/useless code, whereas it makes sense if applied
> along with 2/2.

So, there are 2 patches and 2 custodians. One of you has to ack the
patch for the other to merge them both through the other's subsystem,
right? I guess you want Anatolij to take both of these through the video
tree based on your comments. If so, can you ack this patch and re-assign
them both in patchwork, so he knows that?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH 1/2] ARM: bcm2835: add missing mbox overscan response field
  2013-10-22 20:27 [U-Boot] [PATCH 1/2] ARM: bcm2835: add missing mbox overscan response field Andre Heider
  2013-10-23 16:54 ` Stephen Warren
@ 2013-11-08 12:13 ` Albert ARIBAUD
  2013-11-09 10:11 ` Anatolij Gustschin
  2 siblings, 0 replies; 8+ messages in thread
From: Albert ARIBAUD @ 2013-11-08 12:13 UTC (permalink / raw)
  To: u-boot

Hi Andre,

On Tue, 22 Oct 2013 22:27:20 +0200, Andre Heider <a.heider@gmail.com>
wrote:

> Add the missing "right" field to struct bcm2835_mbox_tag_overscan.
> 
> Signed-off-by: Andre Heider <a.heider@gmail.com>
> ---
>  arch/arm/include/asm/arch-bcm2835/mbox.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/include/asm/arch-bcm2835/mbox.h b/arch/arm/include/asm/arch-bcm2835/mbox.h
> index 24abe57..6b806ec 100644
> --- a/arch/arm/include/asm/arch-bcm2835/mbox.h
> +++ b/arch/arm/include/asm/arch-bcm2835/mbox.h
> @@ -350,6 +350,7 @@ struct bcm2835_mbox_tag_overscan {
>  			u32 top;
>  			u32 bottom;
>  			u32 left;
> +			u32 right;
>  		} resp;
>  	} body;
>  };

Acked-by: Albert ARIBAUD <albert.u.boot@aribaud.net>

Amicalement,
-- 
Albert.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH 1/2] ARM: bcm2835: add missing mbox overscan response field
  2013-11-07 21:30       ` Stephen Warren
@ 2013-11-08 12:16         ` Albert ARIBAUD
  0 siblings, 0 replies; 8+ messages in thread
From: Albert ARIBAUD @ 2013-11-08 12:16 UTC (permalink / raw)
  To: u-boot

Hi Stephen,

On Thu, 07 Nov 2013 14:30:54 -0700, Stephen Warren
<swarren@wwwdotorg.org> wrote:

> So, there are 2 patches and 2 custodians. One of you has to ack the
> patch for the other to merge them both through the other's subsystem,
> right? I guess you want Anatolij to take both of these through the video
> tree based on your comments. If so, can you ack this patch and re-assign
> them both in patchwork, so he knows that?

Done (although I suspect that in this instance, my Ack was not really
needed, as the change was quite trivial and did not require any ARM-
specific knowledge).

Amicalement,
-- 
Albert.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH 1/2] ARM: bcm2835: add missing mbox overscan response field
  2013-10-22 20:27 [U-Boot] [PATCH 1/2] ARM: bcm2835: add missing mbox overscan response field Andre Heider
  2013-10-23 16:54 ` Stephen Warren
  2013-11-08 12:13 ` Albert ARIBAUD
@ 2013-11-09 10:11 ` Anatolij Gustschin
  2 siblings, 0 replies; 8+ messages in thread
From: Anatolij Gustschin @ 2013-11-09 10:11 UTC (permalink / raw)
  To: u-boot

On Tue, 22 Oct 2013 22:27:20 +0200
Andre Heider <a.heider@gmail.com> wrote:

> Add the missing "right" field to struct bcm2835_mbox_tag_overscan.
> 
> Signed-off-by: Andre Heider <a.heider@gmail.com>
> ---
>  arch/arm/include/asm/arch-bcm2835/mbox.h | 1 +
>  1 file changed, 1 insertion(+)

applied to u-boot-video/master, thanks!

Anatolij

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2013-11-09 10:11 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-22 20:27 [U-Boot] [PATCH 1/2] ARM: bcm2835: add missing mbox overscan response field Andre Heider
2013-10-23 16:54 ` Stephen Warren
2013-10-23 19:46   ` Andre Heider
2013-11-07 13:29     ` Albert ARIBAUD
2013-11-07 21:30       ` Stephen Warren
2013-11-08 12:16         ` Albert ARIBAUD
2013-11-08 12:13 ` Albert ARIBAUD
2013-11-09 10:11 ` Anatolij Gustschin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox