public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] Commit 2108f4c4 causes a warning in 10 ARM boards
Date: Sat, 9 Nov 2013 13:55:16 +0100	[thread overview]
Message-ID: <20131109135516.030dcdfd@lilith> (raw)
In-Reply-To: <527E280F.2090303@ti.com>

Hi Tom,

On Sat, 9 Nov 2013 07:18:23 -0500, Tom Rini <trini@ti.com> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 11/09/2013 04:49 AM, Albert ARIBAUD wrote:
> > Hi Rob,
> > 
> > Commit 2108f4c4 ("config: consolidate CONFIG_SYS_HZ definition") causes
> > the following boards:
> > 
> > 	omap730p2_cs3boot omap730p2_cs0boot scb9328 palmtc balloon3
> > 	mini2440 zipitz2 palmld omap730p2 omap3_zoom2 mx1ads
> > 
> > to emit this warning:
> > 
> > 	time.c:12:2: warning: #warning "CONFIG_SYS_HZ must be 1000 and
> > 	should not be defined by platforms" [-Wcpp]
> > 
> > Rob, can you look into it?
> > 
> > Tom: I am preparing a PR from ARM to u-boot; ARM build will obviously
> > fail for these 10 boards unless a fix is applied to u-boot/master before
> > I submit my PR.
> 
> This is intentional, as those boards have CONFIG_SYS_HZ wrong.  For the
> PXA boards, Marek posted a patch that fixes them.  For omap730p2* I plan
> to submit a patch to just yank them out.  For the others, we need to
> find the board maintainer and get them to correct things, or pull them
> as well.

OK -- sorry for the noise, then.

Amicalement,
-- 
Albert.

      reply	other threads:[~2013-11-09 12:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-09  9:49 [U-Boot] Commit 2108f4c4 causes a warning in 10 ARM boards Albert ARIBAUD
2013-11-09 12:18 ` Tom Rini
2013-11-09 12:55   ` Albert ARIBAUD [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131109135516.030dcdfd@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox