From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Mon, 11 Nov 2013 14:29:38 +0100 Subject: [U-Boot] [PATCH v2] usb: dfu: make nand upload working In-Reply-To: <528092AF.4050901@atmel.com> References: <1383805781-23146-1-git-send-email-voice.shen@atmel.com> <52807D51.4090206@denx.de> <528092AF.4050901@atmel.com> Message-ID: <201311111429.38965.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Bo Shen, > Hi Heiko, > > On 11/11/2013 02:46 PM, Heiko Schocher wrote: > > Hello Lukasz, > > > > Am 08.11.2013 16:41, schrieb Lukasz Majewski: > >> Hi Bo, > >> > >>> Nowhere pass a value to len, which always 0, make no transfer which > >>> cause uploading failed. > >>> > >>> This patch make nand upload working. However it needs enough malloc > >>> buffer to store read data, that means the buffer at least equal to > >>> the upload partition size, or else it doesn't work. > >>> > >>> Signed-off-by: Bo Shen > >> > >> I would kindly ask some users of NAND part of the DFU (Tom, Heiko) to > >> test if this change doesn't break anything. > > > > I sent a tested-by for this patch, see: > > > > http://lists.denx.de/pipermail/u-boot/2013-November/166552.html > > > > without this patch nand upload didn;t worked on the rut board, with > > this patch it worked :-) > > Thanks for testing it. Thanks guys, PR is already on it's way to mainline. Best regards, Marek Vasut